Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typescript-vite: fix(frontend): various further fixes/cleanups #6697

Merged
merged 4 commits into from
Jan 20, 2025
Merged

typescript-vite: fix(frontend): various further fixes/cleanups #6697

merged 4 commits into from
Jan 20, 2025

Conversation

JoltCode
Copy link
Collaborator

@JoltCode JoltCode commented Jan 19, 2025 •
edited
Loading

Fixes:

  • TaskSelection page runtime error, added ternary operators to user state accessors
  • DownloadAsCSV proptype warning, should be expecting an object, was expecting string
  • Rename test file - was missing .test.jsx file suffix
  • Missing ternary in lockedTasks

@JoltCode JoltCode requested a review from spwoodcock January 19, 2025 00:35
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@JoltCode JoltCode changed the title typescript-vite: fix(frontend): contribute button click breaking, download as csv proptype warning typescript-vite: fix(frontend): various further fixes/cleanups Jan 19, 2025
@spwoodcock spwoodcock merged commit 8fc6852 into hotosm:typescript-vite Jan 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spwoodcock spwoodcock spwoodcock approved these changes

Assignees
No one assigned
Labels
scope: frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoltCode @spwoodcock