Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Code Coverage and Improve Test Coverage #9

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

katporks
Copy link
Collaborator

@katporks katporks commented Jan 20, 2024

This pull request includes several changes aimed at setting up code coverage and improving the test coverage of the codebase:

  1. Added coverage.py to the project and increased the test coverage.
  2. Removed unnecessary global test lines from the codebase.
  3. Added a coverage test command to the Makefile.
  4. Integrated coverage reporting into pytest GitHub Actions workflow (switched command from pytest to one using coverage.py). Coverage information will be displayed within the log on each pull request.

These changes will help us monitor and improve the quality of our tests, ensuring that our codebase remains robust and reliable as it grows.

@katporks katporks changed the title Added coverage.py and increased coverage Setup Code Coverage and Improve Test Coverage Jan 22, 2024
@katporks katporks marked this pull request as ready for review January 22, 2024 05:17
Copy link
Member

@spwoodcock spwoodcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 😄

BTW, the description says you added a Github Workflow for coverage, but I can't see one.

@spwoodcock
Copy link
Member

I took some inspiration from you and decided to add coverage to FMTM.

I will add a reusable GH-workflow to run coverage and generate a HTML output.

I will also look at adding the total coverage as a badge to the README.

Will ping you after it's done 👍

@katporks
Copy link
Collaborator Author

Neat 😄

BTW, the description says you added a Github Workflow for coverage, but I can't see one.

Oops, my bad! I'll change the description. I just changed the command I passed to the pytest workflow 👍🏼

@katporks katporks merged commit 6598795 into main Jan 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants