Fixed: Unable to select none as product store on settings page(#367) #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymaheshwari1
requested changes
Dec 22, 2023
| @@ -519,7 +519,7 @@ export default defineComponent({ | |||
| async setEComStore(event: any) { | |||
| // not updating the ecomstore when the current value in vuex state and selected value are same | |||
| // or when an empty value is given (on logout) | |||
| if (this.currentEComStore.productStoreId === event.detail.value || !event.detail.value) { | |||
| if (this.currentEComStore.productStoreId === event.detail.value) { | |||
There was a problem hiding this comment.
Need to find some other way to fix this, as removing the above check will result in error on logout(as added in comment)
|
Closing as will be handled differently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #367
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance