Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call sendDialogResult from onDialogDismiss (Fixes #63) #69

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

harshalbhakta
Copy link

Fixes #63

onDialogCancel gets called when dialog is dismissed by pulling down. Everything works as expected. Screen does not freeze.

fun onDialogCancel() {
logEvent("fragment.onDialogCancel", "location" to location)
if (!sessionViewModel.modalResultExists) {
sessionViewModel.sendDialogResult()
}
}

onDialogDismiss gets called when close button is clicked. The screen freezes here.

fun onDialogDismiss() {
logEvent("fragment.onDialogDismiss", "location" to location)
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

App freezes after closing modal with X button
1 participant