Fix small error in iOS documentation #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a small error in the iOS documentation that I ran into. The old documentation stated that the bridge components must be registered before routing your first URL. However, because the userAgent is checked to determine if we are in a Hotwire app and therefore if the bridge components should be activated **and** because this userAgent is established when the root view controller is created you need to register your bridge components first.
|
FWIW there is a PR that might fix this issue, but it would be really helpful to update the docs in the meantime so that people don't run into it. |
|
Thanks for pointing that PR out. It looks like my description is not fully correct. I assumed that it was the rootviewcontroller creation but it is really the Navigator. Looks like the fix will address the root issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a small error in the iOS documentation that I ran into. The old documentation stated that the bridge components must be registered before routing your first URL. However, because the userAgent is checked to determine if we are in a Hotwire app and therefore if the bridge components should be activated and because this userAgent is established when the root view controller is created you need to register your bridge components first.