Fix #27: Make sure only one listener is running #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, only enable hotwire-spark when starting the Rails server. This prevents starting multiple listeners which can occur if one starts the Rails console or runs a script (`rails runner`).
jacob-carlborg-apoex
force-pushed
the
multiple-listeners-27
branch
from
d7f15a2 to
725ee06
Compare
jorgemanrubia
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
This is a fantastic fix @jacob-carlborg-apoex, thank you so much. Sorry I didn't understand what you meant the other day 🙏. Good test also 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, only enable hotwire-spark when starting the Rails server. This prevents starting multiple listeners which can occur if one starts the Rails console or runs a script (
rails runner).Technically it's still possible to run multiple listeners if one explicitly enables hotwire-spark. To prevent this, some form of resource shared between multiple processes are required (like a file lock). This seems to be more complicated than it's worth.