Add basic sprockets support #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Wonderful @codergeek121 thanks a lot.
All the apps I'm currently managing are using propshaft. Did you get to test this with an app using sprockets? Could youf confirm this fixed #36?
Add hotwire_spark.js to the precompiled assets. This adds Sprockets support for Rails 8 applications. Fixes hotwired#36.
codergeek121
force-pushed
the
support-sprockets
branch
from
6b56567 to
6dd01b8
Compare
I created a simple Rails 7 Application with Sprockets, upgraded it to Rails 8 and tested my change against this app. Without my change, this would raise (because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add hotwire_spark.js to the precompiled assets. This adds Sprockets support for Rails 8 applications. Fixes #36.