Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Already known devices not used on second discover #1

Open
marceljaehn opened this issue Oct 18, 2020 · 0 comments
Open

Already known devices not used on second discover #1

marceljaehn opened this issue Oct 18, 2020 · 0 comments

Comments

@marceljaehn
Copy link

In doDiscover null is given as second argument, instead of the list of known devices: https://github.com/HouseOS/secure_control_protocol/blob/66d2fdd7e9c55d80089736c2d24e652daa29f906/lib/scp.dart#L59

This leads to the passwort beeing null, because the list of known devices is empty, even when a device is already provisioned and thus not using the default passwort.
https://github.com/HouseOS/secure_control_protocol/blob/66d2fdd7e9c55d80089736c2d24e652daa29f906/lib/scp_response_parser.dart#L32-L38

Due to the usage of the default password, when in fact the device already has a passwort, leads to an incorrect value when calculating the HMac in
https://github.com/HouseOS/secure_control_protocol/blob/66d2fdd7e9c55d80089736c2d24e652daa29f906/lib/scp_crypto.dart#L103-L109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marceljaehn