Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: map marker endpoint (#4453) #799

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

mcgarrye
Copy link
Collaborator

This PR addresses #(889)

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Creates a public endpoint to return the id, longitude, and latitude of every open listing called mapMarkers.

The existing list endpoint will be used with view params to handle the other endpoint case.

How Can This Be Tested/Reviewed?

Using OpenAPI or by hitting the API directly through another client, call listings/mapMarkers
Verify only open listing id's are returned and check the lat and long returned matches what is in the db.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

* feat: map marker endpoint

* feat: unit test

* feat: integration tests

* feat: correct unit test

* feat: style corrections
@mcgarrye mcgarrye added 1 review needed release A PR that is pulling over a commit(s) from core labels Oct 30, 2024
Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for housing-sanjoseca-gov ready!

Name Link
🔨 Latest commit 52aea04
🔍 Latest deploy log https://app.netlify.com/sites/housing-sanjoseca-gov/deploys/67228c3ebf5eb60008853dd2
😎 Deploy Preview https://deploy-preview-799--housing-sanjoseca-gov.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@ColinBuyck ColinBuyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🪧

@mcgarrye mcgarrye merged commit 6ee2728 into main Nov 6, 2024
45 checks passed
@mcgarrye mcgarrye deleted the release/new-map-endpoints branch November 6, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release A PR that is pulling over a commit(s) from core
Development

Successfully merging this pull request may close these issues.

2 participants