Skip to content

Commit

Permalink
ci: fix clean PR image tags
Browse files Browse the repository at this point in the history
  • Loading branch information
fredleger committed Jan 14, 2025
1 parent fb0dc2c commit 969ed1d
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/pull-request-clean.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ jobs:
matrix:
image: ${{ fromJson(needs.get-available-images-matrix.outputs.images-matrix) }}
steps:
- uses: hoverkraft-tech/ci-github-container/actions/docker/prune-pull-requests-image-tags@v0.9.2
- uses: hoverkraft-tech/ci-github-container/actions/docker/prune-pull-requests-image-tags@0.19.0
with:
image: ${{ matrix.image }}
2 changes: 2 additions & 0 deletions images/ci-helm/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
ARG version=v3.12.0
FROM quay.io/helmpack/chart-testing:${version}

LABEL org.opencontainers.image.source = "https://github.com/hoverkraft-tech/docker-base-images"

Check warning on line 4 in images/ci-helm/Dockerfile

View workflow job for this annotation

GitHub Actions / Continuous Integration / build-images / Build image ci-helm for linux/amd64

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 4 in images/ci-helm/Dockerfile

View workflow job for this annotation

GitHub Actions / Continuous Integration / build-images / Build image ci-helm for linux/arm64

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

# we can probably ignore warning about versions of such packages
# hadolint ignore=DL3018
RUN apk add --no-cache jq yq curl openssl git
Expand Down
2 changes: 2 additions & 0 deletions images/mydumper/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
FROM ubuntu:jammy

LABEL org.opencontainers.image.source = "https://github.com/hoverkraft-tech/docker-base-images"

Check warning on line 3 in images/mydumper/Dockerfile

View workflow job for this annotation

GitHub Actions / Continuous Integration / build-images / Build image mydumper for linux/amd64

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 3 in images/mydumper/Dockerfile

View workflow job for this annotation

GitHub Actions / Continuous Integration / build-images / Build image mydumper for linux/arm64

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

ENV DEBIAN_FRONTEND=noninteractive \

Check warning on line 5 in images/mydumper/Dockerfile

View workflow job for this annotation

GitHub Actions / Continuous Integration / build-images / Build image mydumper for linux/amd64

Sensitive data should not be used in the ARG or ENV commands

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "MYSQL_PASSWORD") More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

Check warning on line 5 in images/mydumper/Dockerfile

View workflow job for this annotation

GitHub Actions / Continuous Integration / build-images / Build image mydumper for linux/arm64

Sensitive data should not be used in the ARG or ENV commands

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "MYSQL_PASSWORD") More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/
TZ=UTC \
MYSQL_HOST=mysql \
Expand Down

0 comments on commit 969ed1d

Please sign in to comment.