Feat/v4

[fabriziomoscon]

No description provided.

[fabriziomoscon]

@Pagebakers @gitstud my intention is to release breaking changes with this branch and on top of it add #130
any help in testing this would br greatly appreciated.

[jdegger]

@fabriziomoscon when you have a working fork (with or without breaking changes) which works for both iOS and Android, we are willing to immediately test it throughougly for you. Please ping us when we are needed!

(cc: @wesdewitte)

[fabriziomoscon]

@jdegger I have been testing this branch for a long time and it works on real device for real calls, but it doesn't use Twilio's latest library, because I didn't notice there were going to be deprecations. The code in #130 should be added on top of it to test more, then we will need to add the new iOS twilio SDK and integrate changes

[jdegger]

@fabriziomoscon Sounds good. Your work is aimed at SDK4, however SDK5 is already been released. Would this be an opportunity to immediately go for V5?

At the moment we do not have the development power to actually help with the PR, however let me know if it needs any testing or if you need help on any other aspect.

[Pagebakers]

Great to see some action here :)

I'll have a look if I can merge this next week.

[fabriziomoscon]

@jdegger this branch is called v4 for RNtwilio breaking changes from v3, when I started the work there weren't SDK above V2 from twilio.
I need to look better into #130 to fully answer your question.

[fabriziomoscon]

Correction: Yesterday I mistaken referenced issue 127 when I meant PR 130 - changed my comments.

[gitstud]

Commits are clean! I will try to test this out on iOS this weekend

[aniravi24]

Is this PR removing the firebase service on Android that shows notifications for your incoming calls->ongoing calls->missed calls? Or does that still work?

[fabriziomoscon]

@aniravi24 if that is the case it was not done on purpose.
implementation 'com.google.firebase:firebase-messaging:17.+' is still there.
I guess I will need to test more for this specific case on Android.

[aniravi24]

Got it. I saw it was removed from AndroidManifest.xml so that's why I thought it was being removed.

[gitstud]

I didn't see my logs in deviceReady or deviceNotReady, I was able to make an outbound call and hangup

[aniravi24]

Working fine on Android for us! Ignore my earlier comment above, I misread the changes being made. We'll give iOS a test soon too (I assume it'll work fine given that the only thing that seems to have changed is renaming of some properties on the iOS side).

[aniravi24]

Looks good.

[fabriziomoscon]

these commits are now included into #144