-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twilio Voice Android SDK 5 #142
Twilio Voice Android SDK 5 #142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this.
Having formatting and line swaps into the PR makes it really difficult to understand your changes. Please create a new PR with only changes and next we can do formatting.
@fabriziomoscon sorry about that! Accidentally let Android studio format everything. Instead of making a whole new PR, mind if I leave GitHub comments in the places where I actually made changes? Would that work for now? |
Formatting should always be added as a separate commit. The reason is not limited to code review, since the commit history will be used by users to understand when and what change has been added when they are debugging their app. |
Got it - will do another PR when I get a chance with only the changes made. |
@aniravi24 thanks for your contributions. |
@fabriziomoscon sorry for the delay! Thank you for doing that. That code comes straight from the Twilio quickstart for Android. |
This builds on top of the migration to Android SDK v4.
Definitely load the diff for the main voice module - that's where most of the changes are. The readme hasn't been updated to indicate the different states that are hardcoded in the module - still haven't totally decided on that but it works! Many of the changes are just Android studio formatting.
I'd also like to update the package version to 5.0.0 - maybe we should keep it the same version as the twilio libraries we use so it's less confusing.