-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating mastodon links and page #39
Conversation
The changes here will link the icon to mastodon directly, and all links (except for email) now have a _blank target. The portal and home page link to our Mastodon page where there is a large obvious button to click to join, so the user flow should be like Mastodon -> Join Us On Mastodon -> Mastodon page. I am adding the icon as an svg because I would have to re-generate the icomoon font and I would rather do that only if absolutely necessary! This seems to look OK, granted that I sized it down to match the others. Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
✅ Deploy Preview for hpc-social ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
New icon isn't rendering in preview - taking a look. |
okay I see the issues - going to push a fix. |
Signed-off-by: vsoch <[email protected]>
Previews in the PR look good. Out of curiosity, why doesn't the icon show up in the Netlify preview after the fix that made it work in the posted previews? |
The reason it didn't work for the first push was because the URL to provide the icon from the hpc.social domain doesn't exist yet. The fix uses a hard slash that will honor whatever root domain is provided (including the preview site). This should always work for the site here, and only will have issue if this template is moved to a subdomain site (e.g., like the map). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to get better about doing reviews instead of just proceeding to the merge. I did look over the preview however and it looks good.
Yeah! That's why I wanted to get Netlify previews up quickly - they make reviewing webby stuff really easy (and you don't necessarily need to look at the messy code if you know where on the site to look). I really love Netlify - I wish their free tier was larger I'd use it all over the place. We only get 300 builds / month. Now that I think of it - when we merge, we are using up build time. I think what we will need to do moving forward is adding a |
This will address a few issues:
The user flow (for someone that comes to the site looking to join Mastodon) could be either of the following:
Signed-off-by: vsoch [email protected]