Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating mastodon links and page #39

Merged
merged 3 commits into from
Nov 27, 2022
Merged

updating mastodon links and page #39

merged 3 commits into from
Nov 27, 2022

Conversation

vsoch
Copy link
Collaborator

@vsoch vsoch commented Nov 26, 2022

This will address a few issues:

The user flow (for someone that comes to the site looking to join Mastodon) could be either of the following:

  • Click the icon to go directly there (new tab)
  • Click "Mastodon" to go to the Mastodon page, and see the obvious button to join.

Signed-off-by: vsoch [email protected]

The changes here will link the icon to mastodon directly,
and all links (except for email) now have a _blank target.
The portal and home page link to our Mastodon page where
there is a large obvious button to click to join, so the
user flow should be like Mastodon -> Join Us On Mastodon ->
Mastodon page. I am adding the icon as an svg because I would
have to re-generate the icomoon font and I would rather do
that only if absolutely necessary! This seems to look OK,
granted that I sized it down to match the others.

Signed-off-by: vsoch <[email protected]>
@netlify
Copy link

netlify bot commented Nov 26, 2022

Deploy Preview for hpc-social ready!

Name Link
🔨 Latest commit 19ef57c
🔍 Latest deploy log https://app.netlify.com/sites/hpc-social/deploys/63829fd35a94f30008c9104f
😎 Deploy Preview https://deploy-preview-39--hpc-social.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vsoch
Copy link
Collaborator Author

vsoch commented Nov 26, 2022

New icon isn't rendering in preview - taking a look.

@vsoch
Copy link
Collaborator Author

vsoch commented Nov 26, 2022

okay I see the issues - going to push a fix.

@vsoch
Copy link
Collaborator Author

vsoch commented Nov 26, 2022

Previews:

image
image

@vsoch vsoch requested a review from alansill November 26, 2022 23:25
@alansill
Copy link
Contributor

Previews in the PR look good. Out of curiosity, why doesn't the icon show up in the Netlify preview after the fix that made it work in the posted previews?

@vsoch
Copy link
Collaborator Author

vsoch commented Nov 27, 2022

The reason it didn't work for the first push was because the URL to provide the icon from the hpc.social domain doesn't exist yet. The fix uses a hard slash that will honor whatever root domain is provided (including the preview site). This should always work for the site here, and only will have issue if this template is moved to a subdomain site (e.g., like the map).

@alansill alansill merged commit f2f563e into main Nov 27, 2022
@alansill alansill deleted the update/mastodon-page branch November 27, 2022 00:13
Copy link
Contributor

@alansill alansill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to get better about doing reviews instead of just proceeding to the merge. I did look over the preview however and it looks good.

@vsoch
Copy link
Collaborator Author

vsoch commented Nov 27, 2022

Yeah! That's why I wanted to get Netlify previews up quickly - they make reviewing webby stuff really easy (and you don't necessarily need to look at the messy code if you know where on the site to look). I really love Netlify - I wish their free tier was larger I'd use it all over the place. We only get 300 builds / month.

Now that I think of it - when we merge, we are using up build time. I think what we will need to do moving forward is adding a [skip ci] to every PR as a squash and merge in the message, and that way it will skip. See https://answers.netlify.com/t/support-guide-how-can-i-optimize-my-netlify-build-time/3907/5 I can't find any global way to disable building the production branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mastodon links page is redundant Links on home page with other social media icons for Mastodon
2 participants