This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
update bundled Lark #1792
Merged
update bundled Lark #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidpr
reviewed
Jan 10, 2024
packaging/fedora/upstream.spec
Outdated
| Provides: bundled(python%{python3_pkgversion}-lark-parser) = 0.11.3 | ||
| Provides: bundled(python%{python3_pkgversion}-lark-parser) = 1.1.8 |
There was a problem hiding this comment.
I don't know what this file is about — something related to Jordan’s out-of-tree RPM packaging — and it looks pretty stale, so I think this PR should probably not change it. charliecloud.spec is the one we test.
reidpr
reviewed
Jan 17, 2024
There was a problem hiding this comment.
The change looks great but it doesn’t solve the linked issue (#1064), which is to update the code to require the updated Lark, taking advantage of any new features and removing workarounds for old bugs.
I’m inclined to merge this but remove the link. Opinions?
|
Omg you're right. That's what I get for leaving a PR open over the winter closure. Your suggestion of unlinking the issue and merging sounds good to me, I can address #1064 in a separate PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closesrelated to #1064