Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

block mknod(2) only if creating a device #1808

Merged
merged 8 commits into from
Jan 18, 2024
Merged

block mknod(2) only if creating a device #1808

merged 8 commits into from
Jan 18, 2024

Conversation

reidpr
Copy link
Collaborator

@reidpr reidpr commented Jan 12, 2024

Also closes #1779.

@reidpr reidpr added this to the 0.36 milestone Jan 12, 2024
@reidpr reidpr self-assigned this Jan 12, 2024
@reidpr reidpr requested review from j-ogas and kchilleri January 12, 2024 20:10
j-ogas
j-ogas approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@j-ogas j-ogas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the answer to my question in-line is "yes", LGTM.

bin/ch_core.c Show resolved Hide resolved
@reidpr
Copy link
Collaborator Author

reidpr commented Jan 17, 2024

Internal CI fails for unrelated reasons. Once that passes I plan to merge without re-review, unless the changes get too large.

@reidpr
Copy link
Collaborator Author

reidpr commented Jan 18, 2024

Internal CI failed for different unrelated reasons. The spack example did build fine. I’m reasonably confident this PR is OK. Merging.

@reidpr reidpr merged commit 07f5a45 into master Jan 18, 2024
6 checks passed
@reidpr reidpr deleted the mknod_1779 branch January 18, 2024 00:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@j-ogas j-ogas j-ogas approved these changes

@kchilleri kchilleri kchilleri approved these changes

Assignees

@reidpr reidpr

Labels
bug image medium runtime
Projects
None yet
Milestone
0.36
Development

Successfully merging this pull request may close these issues.

Spack example does not build with v0.21.0
3 participants
@reidpr @j-ogas @kchilleri