Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

add papers to README.rst #1809

Merged
merged 7 commits into from
Jan 23, 2024
Merged

add papers to README.rst #1809

merged 7 commits into from
Jan 23, 2024

Conversation

kchilleri
Copy link
Contributor

Add new papers with links to docs.

Add new papers with links to docs.
@kchilleri kchilleri requested a review from reidpr January 17, 2024 18:02
@kchilleri
Copy link
Contributor Author

addresses issue #1750

@reidpr reidpr linked an issue Jan 17, 2024 that may be closed by this pull request
Copy link
Collaborator

@reidpr reidpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kchilleri, very nice first PR! Some things to consider in-line. Happy to chat if you have questions.

README.rst Outdated
Comment on lines 49 to 56
* A more technical resource is our Supercomputing 2017 paper:
https://dl.acm.org/citation.cfm?id=3126925
* A more technical resource is our Supercomputing 2017 paper: https://doi.org/10.1145/3126908.3126925

* Our approach to deploying scientific applications in HPC using Charliecloud’s layer-free, Git-based container
build cache: https://doi.org/10.1145/3624062.3624585

* A performance comparison between three HPC-specific container technologies against a bare metal implementation: https://ieeexplore.ieee.org/document/8950978

* Demonstration of how low-privilege containers solve the increasing demand of software flexibility: https://doi.org/10.6084/m9.figshare.14396099
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Listing the links twice seems awkward to me. One possible solution: remove the technical papers from here, change "how do I credit" to "Publications", and add a pointer to that section below.

That said, I really like how you added a 1-sentence summary for each paper and I want to keep those. Let’s re-frame those into a description of the findings/outcome rather than what we did, though.

README.rst Outdated
Comment on lines 122 to 123
* Reid Priedhorsky and Tim Randles. "Charliecloud: unprivileged containers for user-defined
software stacks in HPC", 2017. In *Proc. Supercomputing*. DOI: `10.1145/3126908.3126925 <https://doi.org/10.1145/3126908.3126925>`_.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to mention we use curly quotes in the source .rst files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this about? The DOI link reference?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s the paper title. E.g. you want:

Reid Priedhorsky and Tim Randles. “Charliecloud: unprivileged containers for user-defined 
  software stacks in HPC”, 2017.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s particularly subtle because Sphinx curlifies the HTML pages automatically and usually gets it right. I think maybe it’s so the man pages get curly quotes too??

@kchilleri kchilleri requested a review from reidpr January 22, 2024 18:51
Copy link
Collaborator

@reidpr reidpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you. If my tidy commit looks OK to you and tests pass, I'll merge.

Copy link
Contributor Author

@kchilleri kchilleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@reidpr reidpr changed the title Update README.rst add papers to README.rst Jan 23, 2024
@reidpr reidpr merged commit 47f6836 into master Jan 23, 2024
6 checks passed
@reidpr reidpr deleted the documentation_1750 branch January 23, 2024 00:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add links to papers to documentation front page
2 participants