Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists Fixes #205

Merged
merged 4 commits into from
Aug 5, 2024
Merged

CMakeLists Fixes #205

merged 4 commits into from
Aug 5, 2024

Conversation

jyoung3131
Copy link
Contributor

Overview

Write an explanation of the PR's goal here.

✨ Change Description/Rationale

  • Update CMakeLists to remove the Release flag which is also specified in cmake/BuildType.cmake. Bump required version of CMake to include support for pulling in JSON tarball.
  • Closes Default build type #197

👀 Reviewer Checklist

  • All GitHub actions and runners have passed if applicable
  • Commits are clean and relevant

✅ PR Checklist

  • Remove or update the template boilerplate text
  • Commits are relevant and combined where appropriate
  • Rebase off spatter-devel
  • Reviewers Requested
  • Projects associated
  • Commits mention issue and/or PR numbers at the bottom of the message
  • Relevant issues are linked into the PR
  • TODOs are completed
  • Reviewer checklist is updated

🚀 TODOs

  • No additional Todos for this PR.

📌 Future Work

  • No additional future work

@jyoung3131 jyoung3131 requested a review from plavin August 5, 2024 17:41
@jyoung3131
Copy link
Contributor Author

Looking at how long the CI tests took (20 versus 2 minutes), I think that the cmake/BuildType.cmake Release flag is not getting picked up...

@plavin plavin merged commit be54959 into hpcgarage:main Aug 5, 2024
3 checks passed
@jyoung3131 jyoung3131 deleted the cmake-fix-1 branch August 5, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default build type
2 participants