Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-1506-tests-for-course-share #268

Merged
merged 6 commits into from
Dec 9, 2024
Merged

N21-1506-tests-for-course-share #268

merged 6 commits into from
Dec 9, 2024

Conversation

GordonNicholasCap
Copy link
Contributor

@GordonNicholasCap GordonNicholasCap commented Dec 2, 2024 •
edited
Loading

Description

  • added tests for sharing courses within the same school

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Screenshots of UI changes

Approval for review

  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

This was referenced Dec 2, 2024
Merged
Merged
MBergCap
MBergCap requested changes Dec 4, 2024
View reviewed changes
cypress/e2e/course/shareCtlTools.feature Outdated Show resolved Hide resolved
cypress/e2e/course/shareCtlTools.feature Outdated Show resolved Hide resolved
cypress/e2e/course/shareCtlTools.feature Outdated Show resolved Hide resolved
cypress/e2e/course/shareCtlTools.feature Outdated Show resolved Hide resolved
cypress/e2e/course/shareCtlTools.feature Outdated Show resolved Hide resolved
cypress/support/pages/course/pageShareCourseModal.js Outdated Show resolved Hide resolved
cypress/support/pages/course/pageShareCourseModal.js Outdated Show resolved Hide resolved
cypress/support/pages/course/pageShareCourseModal.js Outdated Show resolved Hide resolved
cypress/support/pages/course/pageShareCourseModal.js Outdated Show resolved Hide resolved
cypress/support/pages/course/pageShareCourseModal.js Outdated Show resolved Hide resolved
MBergCap
MBergCap approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@MBergCap MBergCap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

cypress/support/pages/course/pageImportCourseModal.js Show resolved Hide resolved
@GordonNicholasCap GordonNicholasCap merged commit 917e9ef into main Dec 9, 2024
1 of 2 checks passed
@GordonNicholasCap GordonNicholasCap deleted the N21-1506-sharing-ctl-tools branch December 9, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBergCap MBergCap MBergCap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GordonNicholasCap @MBergCap