fix room create permission

hpi-schul-cloud · Dec 16, 2024 · 369f3cf · 369f3cf
1 parent ad830cd
commit 369f3cf
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/src/modules/feature/room/roomAuthorization.composable.ts b/src/modules/feature/room/roomAuthorization.composable.ts
@@ -22,8 +22,9 @@ export const useRoomAuthorization = (
 		const permissions = toValue(room)?.permissions ?? [];
 
 		canCreateRoom.value =
-			permissions.includes(Permission.RoomEdit) &&
-			authModule.getUserRoles.includes(Roles.Teacher);
+			authModule.getUserPermissions.includes(
+				Permission.RoomCreate.toLowerCase()
+			) && authModule.getUserRoles.includes(Roles.Teacher);
 		canViewRoom.value = permissions.includes(Permission.RoomView);
 		canEditRoom.value = permissions.includes(Permission.RoomEdit);
 		canDeleteRoom.value = permissions.includes(Permission.RoomDelete);

diff --git a/src/modules/feature/room/roomAuthorization.composable.unit.ts b/src/modules/feature/room/roomAuthorization.composable.unit.ts
@@ -11,18 +11,24 @@ import { createModuleMocks } from "@@/tests/test-utils/mock-store-module";
 import { ref } from "vue";
 import { useRoomAuthorization } from "./roomAuthorization.composable";
 
-type setupParams = { userRoles?: Roles[]; roomPermissions?: Permission[] };
+type setupParams = {
+	userRoles?: Roles[];
+	userPermissions?: Permission[];
+	roomPermissions?: Permission[];
+};
 
 describe("roomAuthorization", () => {
 	const genericSetup = ({
 		userRoles = [],
+		userPermissions = [],
 		roomPermissions = [],
 	}: setupParams) => {
 		const room = ref<RoomDetails>(
 			roomFactory.build({ permissions: roomPermissions })
 		);
 		const authModuleMock = createModuleMocks(AuthModule, {
 			getUserRoles: userRoles,
+			getUserPermissions: userPermissions,
 		});
 		return mountComposable(() => useRoomAuthorization(room), {
 			global: { provide: { [AUTH_MODULE_KEY]: authModuleMock } },
@@ -34,7 +40,7 @@ describe("roomAuthorization", () => {
 			const setup = () => {
 				return genericSetup({
 					userRoles: [Roles.Teacher],
-					roomPermissions: [Permission.RoomEdit],
+					userPermissions: [Permission.RoomCreate],
 				});
 			};