Skip to content

Commit

Permalink
BC-5508: update v-select, v-autocomplete, update docs
Browse files Browse the repository at this point in the history
  • Loading branch information
NFriedo committed Nov 6, 2023
1 parent 68b4fae commit 435b180
Show file tree
Hide file tree
Showing 8 changed files with 18 additions and 9 deletions.
4 changes: 3 additions & 1 deletion VUE3-UPGRADE-RESULTS/VUETIFY-UPGRADE.md
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,10 @@ https://github.com/vuetifyjs/vuetify/issues/13508
- `v-confirmation-dialog` already works
- _TODO:_ refactor all Dialogs that use the `v-custom-dialog` component

## Vuetify Colors
## Vuetify Classes
- `class="red--text"` changed to `class="text-red"`
- `rounded-tr-0` with `rounded-te-0` replaced
- `rounded-tl-0` with `rounded-ts-0` replaced

## Vuetify 3 Bugs

Expand Down
4 changes: 2 additions & 2 deletions src/components/feature-board/shared/BoardAnyTitleInput.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
hide-details="auto"
v-model="modelValue"
variant="solo"
dense
density="compact"
:rows="1"
auto-grow
flat
class="mx-n3 mb-n2"
:placeholder="placeholder"
background-color="transparent"
bg-color="transparent"
ref="titleInput"
:readonly="!isEditMode"
role="heading"
Expand Down
4 changes: 4 additions & 0 deletions src/components/molecules/AddContentModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
:items="coursesOptions"
:label="$t('pages.content.label.chooseACourse')"
data-testid="topicSelector"
variant="underlined"
color="primary"
/>
<transition name="fade">
<v-select
Expand All @@ -30,6 +32,8 @@
:label="$t('pages.content.label.chooseALessonTopic')"
:no-data-text="$t('pages.content.placeholder.noLessonTopic')"
data-testid="courseSelector"
variant="underlined"
color="primary"
/>
</transition>
</div>
Expand Down
5 changes: 3 additions & 2 deletions src/components/molecules/vImportUsersMatchSearch.vue
Original file line number Diff line number Diff line change
Expand Up @@ -119,13 +119,14 @@
"
no-filter
variant="solo"
color="primary"
rounded
small-chips
chips
>
<template #selection="{ attr, on, item, selected }">
<v-chip
v-bind="attr"
:input-value="selected"
:model-value="selected"
color="blue-grey"
class="text-white"
v-on="on"
Expand Down
2 changes: 2 additions & 0 deletions src/components/organisms/Pagination.vue
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
item-value="value"
return-object
active
variant="underlined"
color="primary"
@update:model-value="setPagination"
/>
<div v-if="perPage > 0" class="d-flex align-items-center">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@
"
persistent-hint
variant="underlined"
color="primary"
/>
</v-col>
</v-row>
Expand Down
6 changes: 3 additions & 3 deletions src/components/share/SelectCourseModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@

<template #content>
<div>
<div
class="d-flex flex-row pa-2 mb-4 rounded blue lighten-5 background"
>
<div class="d-flex flex-row pa-2 mb-4 rounded bg-blue-lighten-5">
<div class="mx-2">
<v-icon color="info">{{ mdiInformation }}</v-icon>
</div>
Expand All @@ -45,6 +43,8 @@
persistent-hint
:append-icon="mdiTriangleSmallDown"
:menu-props="{ bottom: true, offsetY: true, nudgeBottom: 28 }"
variant="underlined"
color="primary"
/>
</div>
</template>
Expand Down
1 change: 0 additions & 1 deletion src/components/templates/TasksDashboardMain.vue
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
<v-autocomplete
v-if="showCourseFilter"
v-model="selectedCourseFilters"
small-chips
closable-chips
multiple
clearable
Expand Down

0 comments on commit 435b180

Please sign in to comment.