BC-5523 - Fix time select in submission-element (#2883)

* avoid element movement and focus selected time with keyboard * fix typo in fileElement test
hpi-schul-cloud · Oct 26, 2023 · 5eba5e2 · 5eba5e2
1 parent ad98d60
commit 5eba5e2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/components/feature-board-file-element/FileContentElement.unit.ts b/src/components/feature-board-file-element/FileContentElement.unit.ts
@@ -209,7 +209,7 @@ describe("FileContentElement", () => {
 			});
 
 			describe("when v-card emits keydown.down event", () => {
-				it("should emit move-keyboard:edit event", async () => {
+				it("should not emit move-keyboard:edit event", async () => {
 					const { wrapper } = setup();
 
 					const card = wrapper.findComponent({ ref: "fileContentElement" });
@@ -229,7 +229,7 @@ describe("FileContentElement", () => {
 			});
 
 			describe("when v-card emits keydown.up event", () => {
-				it("should emit move-keyboard:edit event", async () => {
+				it("should not emit move-keyboard:edit event", async () => {
 					const { wrapper } = setup();
 
 					const card = wrapper.findComponent({ ref: "fileContentElement" });

diff --git a/src/components/feature-date-time-picker/TimePicker.vue b/src/components/feature-date-time-picker/TimePicker.vue
@@ -5,6 +5,7 @@
 			:close-on-content-click="false"
 			transition="scale-transition"
 			nudge-bottom="70"
+			max-height="200"
 			min-width="180"
 			@input="onMenuToggle"
 		>
@@ -24,10 +25,11 @@
 					@keypress="isNumberOrColon"
 					@keydown.prevent.space="showTimeDialog = true"
 					@keydown.prevent.enter="showTimeDialog = true"
+					@keydown.up.down.stop
 					@update:error="onError"
 				/>
 			</template>
-			<v-list height="200" class="col-12 pt-1 px-0 overflow-y-auto">
+			<v-list class="col-12 pt-1 px-0 overflow-y-auto">
 				<v-list-item-group color="primary">
 					<div
 						v-for="(timeOfDay, index) in timesOfDayList"