Skip to content

Commit

Permalink
requested changes locale keys
Browse files Browse the repository at this point in the history
  • Loading branch information
IgorCapCoder committed Dec 3, 2024
1 parent 1b96a7a commit a4ec323
Show file tree
Hide file tree
Showing 8 changed files with 98 additions and 100 deletions.
4 changes: 2 additions & 2 deletions src/components/share/ImportModal.unit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ describe("@components/share/ImportModal", () => {
);

expect(infoText.text()).toEqual(
"components.molecules.shareImport.options.ctlTools.infoText.line1"
"components.molecules.shareImport.options.ctlTools.infoText.unavailable"
);
});
it("should also show course file info", () => {
Expand Down Expand Up @@ -176,7 +176,7 @@ describe("@components/share/ImportModal", () => {
);

expect(infoText.element.innerHTML).toEqual(
"components.molecules.shareImport.options.restrictions.infoText.line1"
"components.molecules.shareImport.options.restrictions.infoText.courseFiles"
);
});
});
Expand Down
14 changes: 7 additions & 7 deletions src/components/share/ImportModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
<li data-testid="import-options-personal-data-text">
{{
t(
"components.molecules.shareImport.options.personalData.infoText"
"components.molecules.shareImport.options.restrictions.infoText.personalData"
)
}}
</li>
Expand All @@ -43,42 +43,42 @@
>
{{
t(
"components.molecules.shareImport.options.ctlTools.infoText.line1"
"components.molecules.shareImport.options.ctlTools.infoText.unavailable"
)
}}
</li>
<li v-if="showCtlToolsInfo">
{{
t(
"components.molecules.shareImport.options.ctlTools.infoText.line2"
"components.molecules.shareImport.options.ctlTools.infoText.protected"
)
}}
</li>
<li data-testid="import-modal-coursefiles-info">
{{
t(
"components.molecules.shareImport.options.restrictions.infoText.line1"
"components.molecules.shareImport.options.restrictions.infoText.courseFiles"
)
}}
</li>
<li>
{{
t(
"components.molecules.shareImport.options.restrictions.infoText.line2"
"components.molecules.shareImport.options.restrictions.infoText.etherpad"
)
}}
</li>
<li>
{{
t(
"components.molecules.shareImport.options.restrictions.infoText.line3"
"components.molecules.shareImport.options.restrictions.infoText.geogebra"
)
}}
</li>
<li>
{{
t(
"components.molecules.shareImport.options.restrictions.infoText.line4"
"components.molecules.shareImport.options.restrictions.infoText.courseGroups"
)
}}
</li>
Expand Down
2 changes: 1 addition & 1 deletion src/components/share/ShareModal.unit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ describe("@/components/share/ShareModal", () => {

expect(infotext.isVisible()).toBe(true);
expect(infotext.text()).toEqual(
"components.molecules.shareImport.options.ctlTools.infoText.line1"
"components.molecules.shareImport.options.ctlTools.infoText.unavailable"
);
});
});
Expand Down
122 changes: 60 additions & 62 deletions src/components/share/ShareModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -25,68 +25,66 @@
<div class="mx-2">
<v-icon color="info" :icon="mdiInformation" />
</div>
<div>
<div data-testid="share-options-table-header">
{{
t(
"components.molecules.shareImport.options.tableHeader.InfoText"
)
}}
<ul class="ml-6">
<li data-testid="share-options-personal-data-text">
{{
t(
"components.molecules.shareImport.options.personalData.infoText"
)
}}
</li>
<li
v-if="showCtlToolsInfo"
data-testid="share-modal-external-tools-info"
>
{{
t(
"components.molecules.shareImport.options.ctlTools.infoText.line1"
)
}}
</li>
<li v-if="showCtlToolsInfo">
{{
t(
"components.molecules.shareImport.options.ctlTools.infoText.line2"
)
}}
</li>
<li>
{{
t(
"components.molecules.shareImport.options.restrictions.infoText.line1"
)
}}
</li>
<li>
{{
t(
"components.molecules.shareImport.options.restrictions.infoText.line2"
)
}}
</li>
<li>
{{
t(
"components.molecules.shareImport.options.restrictions.infoText.line3"
)
}}
</li>
<li>
{{
t(
"components.molecules.shareImport.options.restrictions.infoText.line4"
)
}}
</li>
</ul>
</div>
<div data-testid="share-options-table-header">
{{
t(
"components.molecules.shareImport.options.tableHeader.InfoText"
)
}}
<ul class="ml-6">
<li data-testid="share-options-personal-data-text">
{{
t(
"components.molecules.shareImport.options.restrictions.infoText.personalData"
)
}}
</li>
<li
v-if="showCtlToolsInfo"
data-testid="share-modal-external-tools-info"
>
{{
t(
"components.molecules.shareImport.options.ctlTools.infoText.unavailable"
)
}}
</li>
<li v-if="showCtlToolsInfo">
{{
t(
"components.molecules.shareImport.options.ctlTools.infoText.protected"
)
}}
</li>
<li data-testid="share-modal-coursefiles-info">
{{
t(
"components.molecules.shareImport.options.restrictions.infoText.courseFiles"
)
}}
</li>
<li>
{{
t(
"components.molecules.shareImport.options.restrictions.infoText.etherpad"
)
}}
</li>
<li>
{{
t(
"components.molecules.shareImport.options.restrictions.infoText.geogebra"
)
}}
</li>
<li>
{{
t(
"components.molecules.shareImport.options.restrictions.infoText.courseGroups"
)
}}
</li>
</ul>
</div>
</div>
<share-modal-options-form
Expand Down
14 changes: 7 additions & 7 deletions src/locales/de.ts
Original file line number Diff line number Diff line change
Expand Up @@ -656,21 +656,21 @@ export default {
"Link Bereich-Kopie",
"components.molecules.share.courses.mail.body": "Link zum Kurs:",
"components.molecules.share.courses.mail.subject": "Kurs zum Importieren",
"components.molecules.shareImport.options.ctlTools.infoText.line1":
"components.molecules.shareImport.options.ctlTools.infoText.unavailable":
"In Zielschule nicht verfügbare, externe Tools",
"components.molecules.shareImport.options.ctlTools.infoText.line2":
"components.molecules.shareImport.options.ctlTools.infoText.protected":
"Geschützte Einstellungen externer Tools",
"components.molecules.share.courses.options.infoText":
"Mit dem folgenden Link kann der Kurs als Kopie von anderen Lehrkräften importiert werden.",
"components.molecules.shareImport.options.personalData.infoText":
"components.molecules.shareImport.options.restrictions.infoText.personalData":
"Personenbezogene Daten",
"components.molecules.shareImport.options.restrictions.infoText.line1":
"components.molecules.shareImport.options.restrictions.infoText.courseFiles":
"Dateien unter Kurs-Dateien",
"components.molecules.shareImport.options.restrictions.infoText.line2":
"components.molecules.shareImport.options.restrictions.infoText.etherpad":
"Inhalte aus Etherpads",
"components.molecules.shareImport.options.restrictions.infoText.line3":
"components.molecules.shareImport.options.restrictions.infoText.geogebra":
"Geogebra IDs und",
"components.molecules.shareImport.options.restrictions.infoText.line4":
"components.molecules.shareImport.options.restrictions.infoText.courseGroups":
"Kursgruppen",
"components.molecules.shareImport.options.tableHeader.InfoText":
"Folgende Inhalte werden nicht kopiert:",
Expand Down
14 changes: 7 additions & 7 deletions src/locales/en.ts
Original file line number Diff line number Diff line change
Expand Up @@ -647,21 +647,21 @@ export default {
"components.molecules.MintEcFooter.chapters": "Chapter overview",
"components.molecules.share.courses.mail.body": "Link to the course:",
"components.molecules.share.courses.mail.subject": "Course you can import",
"components.molecules.shareImport.options.ctlTools.infoText.line1":
"components.molecules.shareImport.options.ctlTools.infoText.unavailable":
"External tools not available in the target school",
"components.molecules.shareImport.options.ctlTools.infoText.line2":
"components.molecules.shareImport.options.ctlTools.infoText.protected":
"Protected settings of external tools",
"components.molecules.share.courses.options.infoText":
"With the following link, the course can be imported as a copy by other teachers.",
"components.molecules.shareImport.options.personalData.infoText":
"components.molecules.shareImport.options.restrictions.infoText.personalData":
"Personal data",
"components.molecules.shareImport.options.restrictions.infoText.line1":
"components.molecules.shareImport.options.restrictions.infoText.courseFiles":
"Files under Course Files",
"components.molecules.shareImport.options.restrictions.infoText.line2":
"components.molecules.shareImport.options.restrictions.infoText.etherpad":
"Content from Etherpads",
"components.molecules.shareImport.options.restrictions.infoText.line3":
"components.molecules.shareImport.options.restrictions.infoText.geogebra":
"Geogebra IDs and",
"components.molecules.shareImport.options.restrictions.infoText.line4":
"components.molecules.shareImport.options.restrictions.infoText.courseGroups":
"Course groups",
"components.molecules.shareImport.options.tableHeader.InfoText":
"The following content will not be copied:",
Expand Down
14 changes: 7 additions & 7 deletions src/locales/es.ts
Original file line number Diff line number Diff line change
Expand Up @@ -659,21 +659,21 @@ export default {
"components.molecules.share.courses.mail.subject": "Curso de importación",
"components.molecules.share.courses.options.ctlTools.infoText":
"No se copiarán herramientas externas asociadas al curso ni tarjetas de embarque.",
"components.molecules.shareImport.options.ctlTools.infoText.line1":
"components.molecules.shareImport.options.ctlTools.infoText.unavailable":
"Herramientas externas no disponibles en la escuela de destino",
"components.molecules.shareImport.options.ctlTools.infoText.line2":
"components.molecules.shareImport.options.ctlTools.infoText.protected":
"Configuraciones protegidas de herramientas externas",
"components.molecules.share.courses.options.infoText":
"Utilizando el siguiente enlace, otros profesores pueden importar el curso como una copia.",
"components.molecules.shareImport.options.personalData.infoText":
"components.molecules.shareImport.options.restrictions.infoText.personalData":
"Datos personales",
"components.molecules.shareImport.options.restrictions.infoText.line1":
"components.molecules.shareImport.options.restrictions.infoText.courseFiles":
"Archivos en Archivos de curso",
"components.molecules.shareImport.options.restrictions.infoText.line2":
"components.molecules.shareImport.options.restrictions.infoText.etherpad":
"Contenido de Etherpads",
"components.molecules.shareImport.options.restrictions.infoText.line3":
"components.molecules.shareImport.options.restrictions.infoText.geogebra":
"ID de Geogebra y",
"components.molecules.shareImport.options.restrictions.infoText.line4":
"components.molecules.shareImport.options.restrictions.infoText.courseGroups":
"Grupos de cursos",
"components.molecules.shareImport.options.tableHeader.InfoText":
"No se copiará el siguiente contenido:",
Expand Down
14 changes: 7 additions & 7 deletions src/locales/uk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -656,21 +656,21 @@ export default {
"components.molecules.share.courses.mail.subject": "Курс імпорту",
"components.molecules.share.courses.options.ctlTools.infoText":
"Зовнішні інструменти, пов’язані з курсом або посадочними картками, не будуть скопійовані.",
"components.molecules.shareImport.options.ctlTools.infoText.line1":
"components.molecules.shareImport.options.ctlTools.infoText.unavailable":
"Зовнішні інструменти недоступні в цільовій школі",
"components.molecules.shareImport.options.ctlTools.infoText.line2":
"components.molecules.shareImport.options.ctlTools.infoText.protected":
"Захищені налаштування зовнішніх інструментів",
"components.molecules.share.courses.options.infoText":
"Використовуючи наступне посилання, курс може бути імпортований як копія іншими викладачами.",
"components.molecules.shareImport.options.personalData.infoText":
"components.molecules.shareImport.options.restrictions.infoText.personalData":
"Персональні дані",
"components.molecules.shareImport.options.restrictions.infoText.line1":
"components.molecules.shareImport.options.restrictions.infoText.courseFiles":
"Файли в розділі Файли курсу",
"components.molecules.shareImport.options.restrictions.infoText.line2":
"components.molecules.shareImport.options.restrictions.infoText.etherpad":
"Вміст із Etherpads",
"components.molecules.shareImport.options.restrictions.infoText.line3":
"components.molecules.shareImport.options.restrictions.infoText.geogebra":
"Ідентифікатори Geogebra та",
"components.molecules.shareImport.options.restrictions.infoText.line4":
"components.molecules.shareImport.options.restrictions.infoText.courseGroups":
"Групи курсів",
"components.molecules.shareImport.options.tableHeader.InfoText":
"Наступний вміст не буде скопійовано:",
Expand Down

0 comments on commit a4ec323

Please sign in to comment.