Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THR-18: dev feature h5p editor #2748

Merged
merged 72 commits into from
Nov 16, 2023
Merged

Conversation

SteKrause
Copy link
Contributor

@SteKrause SteKrause commented Aug 21, 2023

Short Description

Links to Ticket and related Pull-Requests

BC-5852
PR schulcloud-server: hpi-schul-cloud/schulcloud-server#4337
PR: schulcloud-client: hpi-schul-cloud/schulcloud-client#3277
PR dof_app_deploy: hpi-schul-cloud/dof_app_deploy#682

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

Copy link
Contributor

@SevenWaysDP SevenWaysDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about tests?

src/components/h5p/H5PEditor.vue Outdated Show resolved Hide resolved
src/components/h5p/H5PPlayer.vue Outdated Show resolved Hide resolved
src/components/h5p/H5PPlayer.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@uidp uidp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it looks like this all can be done in a smaller, seperate vue application. We definitely should discuss that.

src/pages/H5PEditor.page.vue Outdated Show resolved Hide resolved
@CeEv CeEv dismissed their stale review November 6, 2023 11:03

Review comments mark as solved.

@MajedAlaitwniCap MajedAlaitwniCap requested a review from uidp November 6, 2023 14:57
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

89.5% 89.5% Coverage
0.0% 0.0% Duplication

@casparneumann-cap casparneumann-cap enabled auto-merge (squash) November 16, 2023 12:03
@casparneumann-cap casparneumann-cap merged commit 16e40e1 into main Nov 16, 2023
42 of 44 checks passed
@casparneumann-cap casparneumann-cap deleted the THR-18-dev-feature-h5p-editor branch November 16, 2023 12:14
@casparneumann-cap casparneumann-cap restored the THR-18-dev-feature-h5p-editor branch November 16, 2023 12:14
@casparneumann-cap casparneumann-cap deleted the THR-18-dev-feature-h5p-editor branch November 20, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants