-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
THR-18: dev feature h5p editor #2748
Conversation
* Create proxy for h5p editor in dev-environment * basic implementation h5p page * id variable and refactoring * added editor page * change and add routes * sonar issues fixed --------- Co-authored-by: Marvin Rode <[email protected]>
* Integrated H5P Webcomponents into Vue client
* add language param to h5p endpoints * generate client server
* Generate API and include parent information * Vue prop types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me it looks like this all can be done in a smaller, seperate vue application. We definitely should discuss that.
Kudos, SonarCloud Quality Gate passed! |
Short Description
Links to Ticket and related Pull-Requests
BC-5852
PR schulcloud-server: hpi-schul-cloud/schulcloud-server#4337
PR: schulcloud-client: hpi-schul-cloud/schulcloud-client#3277
PR dof_app_deploy: hpi-schul-cloud/dof_app_deploy#682
Changes
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging