Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-4913 remove passage on user registration #2782

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

VikDavydiuk
Copy link
Contributor

@VikDavydiuk VikDavydiuk commented Sep 1, 2023

Short Description

QA note:
change tested on env:
https://nbc-bc-4913-remove-passage-on-user-registration.cd.dbildungscloud.dev/
https://default-bc-4913-remove-passage-on-user-registration.cd.dbildungscloud.dev/
https://brb-bc-4913-remove-passage-on-user-registration.cd.dbildungscloud.dev/
No issues found. Text for new admin and old admin page are removed.
See Jira ticket: https://ticketsystem.dbildungscloud.de/browse/BC-4913

Links to Ticket and related Pull-Requests

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@virgilchiriac virgilchiriac changed the title Bc 4913 remove passage on user registration BC-4913 remove passage on user registration Sep 7, 2023
@VikDavydiuk VikDavydiuk enabled auto-merge (squash) September 14, 2023 07:34
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@VikDavydiuk VikDavydiuk merged commit 574de8b into main Sep 14, 2023
@VikDavydiuk VikDavydiuk deleted the BC-4913-Remove-passage-on-user-registration branch September 14, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants