Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-4623-Creation time and update time of status messages #2786

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

Michaellinaresxk
Copy link
Contributor

@Michaellinaresxk Michaellinaresxk commented Sep 4, 2023

Short Description

Links to Ticket and related Pull-Requests

https://ticketsystem.dbildungscloud.de/browse/BC-4623

Changes

Added functinalities to update the date format to present the update and created according those requierments:

  • From 1 to 59 minutes - display "updated [...] minutes ago | created [...] minutes ago". If value=1, the word "minute" is in singular.

  • From 1 hour to 23h 59min - display "updated [...] hours ago | created [...] hours ago". If the value=1, the word "hour" is in singular.

  • From 1 to 6d 23h 59min days - display "updated [...] days ago | created [...] days ago". If value=1, the word "day" is in singular.

  • From 7 days and more - display the date of update in European format | date of creation in European format. For example updated 28.07.2023 | created 21.07.2023 or created 21.07.2023.

The update time is displayed first, then the creation time. The creation time is always displayed, the update time is displayed if there was an update.

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

<!
Created 1 day ago
created 7 days ago
created 1 minute ago

-->

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@Michaellinaresxk Michaellinaresxk added the WIP someone is working on that label Sep 4, 2023
@Michaellinaresxk Michaellinaresxk changed the title testing. BC-4623-Creation time and update time of status messages Sep 4, 2023
@Michaellinaresxk Michaellinaresxk force-pushed the BC-4623-Creation-and-update-status branch from 1d8842f to 40bf0ab Compare September 6, 2023 14:33
@Michaellinaresxk Michaellinaresxk removed the WIP someone is working on that label Sep 6, 2023
@Michaellinaresxk Michaellinaresxk force-pushed the BC-4623-Creation-and-update-status branch 2 times, most recently from 9c02646 to c3a0881 Compare September 11, 2023 17:03
src/plugins/datetime.js Outdated Show resolved Hide resolved
src/plugins/datetime.js Outdated Show resolved Hide resolved
src/plugins/datetime.js Outdated Show resolved Hide resolved
src/plugins/datetime.js Outdated Show resolved Hide resolved
src/plugins/datetime.js Outdated Show resolved Hide resolved
src/plugins/datetime.js Show resolved Hide resolved
src/components/topbar/StatusAlerts.vue Outdated Show resolved Hide resolved
src/components/topbar/StatusAlerts.vue Outdated Show resolved Hide resolved
src/components/topbar/StatusAlerts.vue Show resolved Hide resolved
@Michaellinaresxk Michaellinaresxk force-pushed the BC-4623-Creation-and-update-status branch from 51eaf42 to 882e7b5 Compare September 22, 2023 11:33
bn-pass
bn-pass previously approved these changes Sep 22, 2023
Copy link
Contributor

@virgilchiriac virgilchiriac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI we are working on a date picker, and display the date in vue, where we used localised date formats. We cannot / should not use diferent date formats - but this seems to be the only exception

src/locales/en.json Outdated Show resolved Hide resolved
src/locales/de.json Outdated Show resolved Hide resolved
@virgilchiriac
Copy link
Contributor

I think you should not have to hard-code this labels, but use the dayjs plugin internationalization....It should handle the text by itself.
https://day.js.org/docs/en/display/from-now

src/components/topbar/StatusAlerts.vue Outdated Show resolved Hide resolved
src/locales/de.json Outdated Show resolved Hide resolved
src/locales/de.json Outdated Show resolved Hide resolved
src/plugins/datetime.js Outdated Show resolved Hide resolved
odalys-dataport
odalys-dataport previously approved these changes Oct 4, 2023
@Michaellinaresxk Michaellinaresxk force-pushed the BC-4623-Creation-and-update-status branch from c882876 to 8ae669c Compare October 8, 2023 21:04
@Michaellinaresxk Michaellinaresxk force-pushed the BC-4623-Creation-and-update-status branch from 23a51c0 to ae50eec Compare October 16, 2023 14:25
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 3 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Michaellinaresxk Michaellinaresxk enabled auto-merge (squash) October 17, 2023 14:36
@Michaellinaresxk Michaellinaresxk enabled auto-merge (squash) October 17, 2023 14:37
@Michaellinaresxk Michaellinaresxk merged commit 30ffb07 into main Oct 17, 2023
42 of 43 checks passed
@Michaellinaresxk Michaellinaresxk deleted the BC-4623-Creation-and-update-status branch October 17, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants