-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC-4938 - Add school specific Terms of Use (Nutzungsordnung) for new school admin page #2799
Conversation
src/components/organisms/administration/SchoolTermsFormDialog.vue
Outdated
Show resolved
Hide resolved
src/components/organisms/administration/SchoolTermsFormDialog.vue
Outdated
Show resolved
Hide resolved
src/components/organisms/administration/SchoolTermsFormDialog.vue
Outdated
Show resolved
Hide resolved
>{{ link.text }} | ||
</span> | ||
>{{ link.text }}</span | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preferably adjust format like (same for lines 11-13)
<span>
{{ link.text }}
</span>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mh I wouldn't think that how we format our code should change the ui in any way, but it's not a biggie, so don't worry about it
>{{ link.text }} | ||
</span> | ||
>{{ link.text }}</span | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mh I wouldn't think that how we format our code should change the ui in any way, but it's not a biggie, so don't worry about it
Kudos, SonarCloud Quality Gate passed! 0 Bugs 92.6% Coverage The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
Short Description
Links to Ticket and related Pull-Requests
https://ticketsystem.dbildungscloud.de/browse/BC-4938
hpi-schul-cloud/dof_app_deploy#635
hpi-schul-cloud/schulcloud-server#4399
hpi-schul-cloud/schulcloud-client#3301
Changes
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging