-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
THR-45 Consolidation H5P Editor/Player #2836
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create proxy for h5p editor in dev-environment * basic implementation h5p page * id variable and refactoring * added editor page * change and add routes * sonar issues fixed --------- Co-authored-by: Marvin Rode <[email protected]>
* Integrated H5P Webcomponents into Vue client
* add language param to h5p endpoints * generate client server
* Generate API and include parent information * Vue prop types
3 tasks
This was referenced Sep 29, 2023
SonarCloud Quality Gate failed. 0 Bugs 2.6% Coverage The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Fixes remaining issues of the current state of the H5P editor/player
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/THR-45
hpi-schul-cloud/dof_app_deploy#655
hpi-schul-cloud/schulcloud-server#4449
hpi-schul-cloud/schulcloud-client#3320
Changes
TODO
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging