Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THR-45 Consolidation H5P Editor/Player #2836

Closed
wants to merge 39 commits into from
Closed

THR-45 Consolidation H5P Editor/Player #2836

wants to merge 39 commits into from

Conversation

ssmid
Copy link
Contributor

@ssmid ssmid commented Sep 29, 2023

Short Description

Fixes remaining issues of the current state of the H5P editor/player

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/THR-45
hpi-schul-cloud/dof_app_deploy#655
hpi-schul-cloud/schulcloud-server#4449
hpi-schul-cloud/schulcloud-client#3320

Changes

TODO

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

MajedAlaitwniCap and others added 28 commits June 7, 2023 13:54
* Create proxy for h5p editor in dev-environment

* basic implementation h5p page

* id variable and refactoring

* added editor page

* change and add routes

* sonar issues fixed

---------

Co-authored-by: Marvin Rode <[email protected]>
* Integrated H5P Webcomponents into Vue client
* add language param to h5p endpoints

* generate client server
* Generate API and include parent information

* Vue prop types
@ssmid ssmid added the WIP someone is working on that label Sep 29, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

2.6% 2.6% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@casparneumann-cap casparneumann-cap deleted the THR-preview branch November 22, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP someone is working on that
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants