-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC-5445 - filter submissions #2841
Conversation
src/components/feature-board-submission-element/types/submission.ts
Outdated
Show resolved
Hide resolved
src/components/feature-board-submission-element/components/SubmissionItemStudentDisplay.vue
Outdated
Show resolved
Hide resolved
src/components/feature-board-submission-element/components/SubmissionItemsTeacherDisplay.vue
Outdated
Show resolved
Hide resolved
src/components/feature-board-submission-element/components/SubmissionItemStudentDisplay.vue
Outdated
Show resolved
Hide resolved
…chul-cloud/nuxt-client into BC-5445-filter-submissions
src/components/feature-board-submission-element/components/SubmissionContentElement.vue
Outdated
Show resolved
Hide resolved
src/components/feature-board-submission-element/components/SubmissionContentElementDisplay.vue
Outdated
Show resolved
Hide resolved
...components/feature-board-submission-element/components/SubmissionItemsTeacherDisplay.unit.ts
Outdated
Show resolved
Hide resolved
...components/feature-board-submission-element/components/SubmissionItemsTeacherDisplay.unit.ts
Show resolved
Hide resolved
src/components/feature-board-submission-element/components/SubmissionItemsTeacherDisplay.vue
Outdated
Show resolved
Hide resolved
} | ||
}; | ||
|
||
// Filter Functionality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we really need that comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk, I find the composition api quite heavy to read so I added this comment to mark the filter section. We don't need it, but maybe it's nice to have
and also, what do we do about those code smells? |
src/components/feature-board-submission-element/components/SubmissionItemsTeacherDisplay.vue
Outdated
Show resolved
Hide resolved
SonarCloud Quality Gate failed. 0 Bugs 73.5% Coverage The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Short Description
https://ticketsystem.dbildungscloud.de/browse/BC-5445
Also implements:
https://ticketsystem.dbildungscloud.de/browse/BC-5476
Sorts icons alphabetically in /icons/material/index.ts
Adds two new rules to our eslint config:
The amount of file changes is due to running the linter. The only files relating to the ticket are the submission files.
Links to Ticket and related Pull-Requests
Changes
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging