Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-5445 - filter submissions #2841

Merged
merged 63 commits into from
Oct 19, 2023
Merged

BC-5445 - filter submissions #2841

merged 63 commits into from
Oct 19, 2023

Conversation

odalys-dataport
Copy link
Contributor

@odalys-dataport odalys-dataport commented Oct 4, 2023

Short Description

https://ticketsystem.dbildungscloud.de/browse/BC-5445

Also implements:
https://ticketsystem.dbildungscloud.de/browse/BC-5476

Sorts icons alphabetically in /icons/material/index.ts

Adds two new rules to our eslint config:

  • vue/html-self-closing
  • vue/no-setup-props-reactivity-loss
  • Change no-console and no-debugger to "off" on production and "warning" everywhere else as discussed in FE Arc Group

The amount of file changes is due to running the linter. The only files relating to the ticket are the submission files.

Links to Ticket and related Pull-Requests

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@odalys-dataport odalys-dataport self-assigned this Oct 4, 2023
@odalys-dataport odalys-dataport added the WIP someone is working on that label Oct 6, 2023
}
};

// Filter Functionality
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really need that comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk, I find the composition api quite heavy to read so I added this comment to mark the filter section. We don't need it, but maybe it's nice to have

@MartinSchuhmacher
Copy link
Contributor

and also, what do we do about those code smells?

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

73.5% 73.5% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@odalys-dataport odalys-dataport merged commit e15b9cd into main Oct 19, 2023
@odalys-dataport odalys-dataport deleted the BC-5445-filter-submissions branch October 19, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants