BC-4783 Migrate GET endpoints of school API #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 6, 2023
CeEv
reviewed
Nov 27, 2023
CeEv
reviewed
Nov 27, 2023
CeEv
reviewed
Nov 27, 2023
uidp
previously approved these changes
Nov 30, 2023
uidp
approved these changes
Dec 13, 2023
uidp
previously approved these changes
Dec 13, 2023
CeEv
reviewed
Dec 13, 2023
CeEv
requested changes
Dec 13, 2023
src/store/schools.ts
Outdated
| this.setSystems(responses.map((response) => response.data)); | ||
| this.setLoading(false); | ||
| } catch (error: unknown) { | ||
| if (error instanceof AxiosError) { |
There was a problem hiding this comment.
Sollte der Nutzer nicht auch im else Fall über ein Error informiert werden? Nur loading auf false setzten klinkt nicht richtig.
Es sollte sich ja nur das Error Format unterschieden.
There was a problem hiding this comment.
Ich find das auch komisch, aber das seh ich nicht als Teil dieses PRs, das zu ändern.
CeEv
previously approved these changes
Dec 14, 2023
|
bergatco
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Links to Ticket and related Pull-Requests
https://ticketsystem.dbildungscloud.de/browse/BC-4783
hpi-schul-cloud/schulcloud-server#4440
hpi-schul-cloud/schulcloud-client#3315
Changes
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging