Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-5426 - Add a delete option to the school specific Privacy Policy and Terms of Use #2853

Merged
merged 23 commits into from
Oct 18, 2023
Merged

BC-5426 - Add a delete option to the school specific Privacy Policy and Terms of Use #2853

merged 23 commits into from
Oct 18, 2023

Conversation

davwas
Copy link
Contributor

@davwas davwas commented Oct 9, 2023 •
edited
Loading

Short Description

QA note:
Change tested on env:
https://nbc-bc-5426-delete-policy-terms.cd.dbildungscloud.dev/
https://brb-bc-5426-delete-policy-terms.cd.dbildungscloud.dev/
https://default-bc-5426-delete-policy-terms.cd.dbildungscloud.dev/
No issues found. All accept criteria done.
See JIRA ticket https://ticketsystem.dbildungscloud.de/browse/BC-5426

Links to Ticket and related Pull-Requests

https://ticketsystem.dbildungscloud.de/browse/BC-5426

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@davwas davwas added the waiting for review Someone should review this ASAP label Oct 9, 2023
@davwas davwas self-assigned this Oct 9, 2023
@davwas davwas changed the title BC - 5426 - Add a delete option to the school specific Privacy Policy and Terms of Use BC-5426 - Add a delete option to the school specific Privacy Policy and Terms of Use Oct 9, 2023
blazejpass
blazejpass previously approved these changes Oct 9, 2023
View reviewed changes
blazejpass
blazejpass previously approved these changes Oct 9, 2023
View reviewed changes
blazejpass
blazejpass previously approved these changes Oct 17, 2023
View reviewed changes
blazejpass
blazejpass previously approved these changes Oct 18, 2023
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@davwas davwas merged commit da6e4be into main Oct 18, 2023
42 checks passed
@davwas davwas deleted the BC-5426-delete-policy-terms branch October 18, 2023 11:06
@davwas davwas removed the waiting for review Someone should review this ASAP label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blazejpass blazejpass blazejpass approved these changes

@odalys-dataport odalys-dataport odalys-dataport approved these changes

Assignees

@davwas davwas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davwas @odalys-dataport @blazejpass @wiaderwek