Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-1248 Configure External Tools in Boards #2860

Merged
merged 16 commits into from
Oct 19, 2023
Merged

N21-1248 Configure External Tools in Boards #2860

merged 16 commits into from
Oct 19, 2023

Conversation

MarvinOehlerkingCap
Copy link
Contributor

@MarvinOehlerkingCap MarvinOehlerkingCap commented Oct 12, 2023 •
edited
Loading

Short Description

  • add configuration dialog for external tool elements on boards

Links to Ticket and related Pull-Requests

https://ticketsystem.dbildungscloud.de/browse/N21-1248
hpi-schul-cloud/schulcloud-server#4471

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@MarvinOehlerkingCap MarvinOehlerkingCap mentioned this pull request Oct 12, 2023
Merged
3 tasks
@MarvinOehlerkingCap
Merge branch 'main' into N21-1248-configure-ctl-in-board
1a71e90 
# Conflicts:
#	src/components/feature-board-external-tool-element/ExternalToolElement.unit.ts
#	src/components/feature-board-external-tool-element/ExternalToolElement.vue
#	src/components/feature-board/card/CardHost.unit.ts
#	src/components/feature-board/card/CardHost.vue
#	src/components/feature-board/card/ContentElementList.vue
#	src/locales/de.json
#	src/serverApi/v3/api.ts
@MarvinOehlerkingCap
update api
2524a73
@MarvinOehlerkingCap
dialog test
6943d53
@arnegns arnegns self-requested a review October 13, 2023 13:13
@arnegns
Copy link
Contributor

arnegns commented Oct 16, 2023

The context external tool will not be deleted if i remove the element from a card..

arnegns
arnegns previously approved these changes Oct 16, 2023
View reviewed changes
arnegns
arnegns previously approved these changes Oct 17, 2023
View reviewed changes
arnegns
arnegns previously approved these changes Oct 18, 2023
View reviewed changes
@arnegns arnegns requested a review from OliverHappe October 18, 2023 10:41
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

97.3% 97.3% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@MarvinOehlerkingCap MarvinOehlerkingCap merged commit 0341a18 into main Oct 19, 2023
@MarvinOehlerkingCap MarvinOehlerkingCap deleted the N21-1248-configure-ctl-in-board branch October 19, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OliverHappe OliverHappe OliverHappe left review comments

@arnegns arnegns arnegns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarvinOehlerkingCap @arnegns @OliverHappe