Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix printing qr code #2869

Merged
merged 9 commits into from
Oct 23, 2023
Merged

fix printing qr code #2869

merged 9 commits into from
Oct 23, 2023

Conversation

wiaderwek
Copy link
Contributor

@wiaderwek wiaderwek commented Oct 18, 2023

Short Description

QA note:
Change tested on env:
https://nbc-bc-5526-fix-printing-qr-code.cd.dbildungscloud.dev/
https://brb-bc-5526-fix-printing-qr-code.cd.dbildungscloud.dev/
No issues found. All accepted criteria done: QRcode is show and open.
See movie in JIRA ticket

Links to Ticket and related Pull-Requests

https://ticketsystem.dbildungscloud.de/browse/BC-5526

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@wiaderwek wiaderwek self-assigned this Oct 18, 2023
@wiaderwek wiaderwek force-pushed the BC-5526-fix-printing-qr-code branch from 7036fed to 45f0480 Compare October 18, 2023 15:58
@wiaderwek wiaderwek force-pushed the BC-5526-fix-printing-qr-code branch from 1e39df4 to 7920fe6 Compare October 18, 2023 16:03
@VikDavydiuk VikDavydiuk self-requested a review October 19, 2023 07:04
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@wiaderwek wiaderwek merged commit 7bc2bb2 into main Oct 23, 2023
42 checks passed
@wiaderwek wiaderwek deleted the BC-5526-fix-printing-qr-code branch October 23, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants