Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-1207 show group members #2874

Merged
merged 41 commits into from
Oct 20, 2023
Merged

N21-1207 show group members #2874

merged 41 commits into from
Oct 20, 2023

Conversation

arnegns
Copy link
Contributor

@arnegns arnegns commented Oct 19, 2023 •
edited
Loading

Short Description

Adds new page to show members of a group

Links to Ticket and related Pull-Requests

https://ticketsystem.dbildungscloud.de/browse/N21-1207
hpi-schul-cloud/schulcloud-server#4479

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

image

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

IgorCapCoder and others added 19 commits October 11, 2023 17:02
@IgorCapCoder
add icons to new class view WIP
67631af
@IgorCapCoder
add icons to new class view
7ed64f7
@IgorCapCoder
cleanup
b8eb162
@IgorCapCoder
functionality for action icons and new locales
88e6897
@IgorCapCoder
Merge branch 'main' into N21-1264-new-class-page-extension
123597c
@IgorCapCoder
unit test WIP
e7f16e7
@IgorCapCoder
Merge branch 'main' into N21-1264-new-class-page-extension
913be2e
@IgorCapCoder
Merge branch 'main' into N21-1264-new-class-page-extension
8ecf0df 
# Conflicts:
#	src/pages/administration/ClassOverview.page.unit.ts
#	tests/test-utils/factory/classInfoFactory.ts
@IgorCapCoder
unit tests, todos, merge main
85650b7
@arnegns
N21-1207 init page
f0da3dd
@arnegns
Merge branch 'main' into N21-1207-show-group-members
c2a28c8
@arnegns
N21-1207 wip
532ab32
@IgorCapCoder
Merge branch 'main' into N21-1264-new-class-page-extension
177a6c4 
# Conflicts:
#	src/pages/administration/ClassOverview.page.vue
@IgorCapCoder
request changes, merge main
327d72a
@MarvinOehlerkingCap
add loading of group and system
46ecc09
@arnegns
Merge branch 'main' into N21-1207-show-group-members
9034878
@IgorCapCoder
request changes
3046fd7
@arnegns
N21-1207 some tests
dd7333d
@arnegns
N21-1207 adds tests
f6df0f1
@arnegns arnegns mentioned this pull request Oct 19, 2023
Merged
3 tasks
@arnegns arnegns added the WIP someone is working on that label Oct 19, 2023
MarvinOehlerkingCap
MarvinOehlerkingCap requested changes Oct 20, 2023
View reviewed changes
src/locales/en.json Outdated Show resolved Hide resolved
@arnegns arnegns mentioned this pull request Oct 20, 2023
Merged
1 task
@arnegns
Merge branch 'main' into N21-1207-show-group-members
bc3bedf 
# Conflicts:
#	src/pages/administration/ClassOverview.page.unit.ts
#	src/pages/administration/ClassOverview.page.vue
@arnegns arnegns removed the WIP someone is working on that label Oct 20, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

94.3% 94.3% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@arnegns arnegns enabled auto-merge (squash) October 20, 2023 13:48
@arnegns arnegns merged commit 69eb8c0 into main Oct 20, 2023
42 checks passed
@arnegns arnegns deleted the N21-1207-show-group-members branch October 20, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarvinOehlerkingCap MarvinOehlerkingCap MarvinOehlerkingCap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arnegns @MarvinOehlerkingCap @IgorCapCoder