Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-5434 - meta data endpoint #2876

Merged
merged 46 commits into from
Nov 6, 2023
Merged

BC-5434 - meta data endpoint #2876

merged 46 commits into from
Nov 6, 2023

Conversation

hoeppner-dataport
Copy link
Contributor

@hoeppner-dataport hoeppner-dataport commented Oct 20, 2023 •
edited
Loading

Short Description

Refactoring LinkElement to use new metaDataEndpoint and fileStorage.

Links to Ticket and related Pull-Requests

https://ticketsystem.dbildungscloud.de/browse/BC-5434
hpi-schul-cloud/schulcloud-server#4488

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

This was referenced Oct 20, 2023
Merged
Closed
@hoeppner-dataport
chore: work on menu
fc801f5
@hoeppner-dataport
Merge branch 'main' of github.com:hpi-schul-cloud/nuxt-client into BC…
29bc0e6 
…-5434-meta-data-endpoint
@hoeppner-dataport
fix: sonar cloud regex security concern
938bed6
@hoeppner-dataport
fix: problem with basename being not available in js
e6cd512
@hoeppner-dataport
chore: increase font coverage
d91ded8
@hoeppner-dataport
chore: fix focus handler
45e76af
@hoeppner-dataport
refactor isLoading to be connected to imageUpload
5be2cff
@hoeppner-dataport
chore: refactored filechecks to be composable
eff074c
@hoeppner-dataport
Merge branch 'main' of github.com:hpi-schul-cloud/nuxt-client into BC…
298a933 
…-5434-meta-data-endpoint
@hoeppner-dataport
chore: fix language strings
bcc6fac
@hoeppner-dataport
validate on submit
9f7dd36
@hoeppner-dataport
chore: show menu not only on hover
8635cee
@hoeppner-dataport
extract business logic from component
fc21c2d
@hoeppner-dataport
refactor: logic
c7212b4
@hoeppner-dataport
fix: move down when several elements are new (see BC-5632)
de70b1b
@hoeppner-dataport
chore: fix naming
8aba636
@hoeppner-dataport
use unified header component
3afe947
@hoeppner-dataport
refactor upload handling
bdc2e8a
@hoeppner-dataport
fix: prevent element move during input
4405cbd
@hoeppner-dataport
fix: lineheight in multiline input
280573b
@hoeppner-dataport
fix: put menu back at the right place
c8dc1f4
@hoeppner-dataport
fix: pixel magic for menu positioning
c3c3121
@hoeppner-dataport
chore: test url.util
3af2a97
@hoeppner-dataport
chore: add tests
aaca8c0
@hoeppner-dataport
chore: add tests for LinkContentElementCreate
935eb0f
@hoeppner-dataport
chore: add test for LinkContentElementDisplay
33305c9
@hoeppner-dataport
chore: add test for metaTagExtractorApi.composable
29ebb75
@hoeppner-dataport
Merge branch 'main' of github.com:hpi-schul-cloud/nuxt-client into BC…
a506bd9 
…-5434-meta-data-endpoint
@hoeppner-dataport
chore: removed redundand type definition
959c93a
@hoeppner-dataport
chore: fix test LinkContentElementCreate
fa88922
@hoeppner-dataport
chore: add test for PreviewGenerator.composable
6146f0c
@hoeppner-dataport
chore: remove redundant code
1b3ab81
@hoeppner-dataport
chore: fix sonarcloud detection in mock value
0d16644
@hoeppner-dataport
chore: fix sonarcloud detection in mock value - part 2
7cc1a6c
@hoeppner-dataport
Merge branch 'main' of github.com:hpi-schul-cloud/nuxt-client into BC…
81c3813 
…-5434-meta-data-endpoint
@hoeppner-dataport
update generated api
5095e2f
@hoeppner-dataport
Merge branch 'main' of github.com:hpi-schul-cloud/nuxt-client into BC…
a3e8485 
…-5434-meta-data-endpoint
@hoeppner-dataport
improve onKeydown handling
d60b64c
@hoeppner-dataport
chore: improve tests
00c6071
@hoeppner-dataport
chore: improve method name
bc675d6
@hoeppner-dataport
Merge branch 'main' of github.com:hpi-schul-cloud/nuxt-client into BC…
74d9755 
…-5434-meta-data-endpoint
@hoeppner-dataport
chore: formatting change
32c1b75
OliverHappe
OliverHappe previously approved these changes Nov 6, 2023
View reviewed changes
@hoeppner-dataport hoeppner-dataport enabled auto-merge (squash) November 6, 2023 11:24
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.4% 94.4% Coverage
0.0% 0.0% Duplication

@hoeppner-dataport hoeppner-dataport merged commit 62bc3f3 into main Nov 6, 2023
41 of 42 checks passed
@hoeppner-dataport hoeppner-dataport deleted the BC-5434-meta-data-endpoint branch November 6, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OliverHappe OliverHappe OliverHappe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoeppner-dataport @OliverHappe