N21-1318 add schoolyear dependent tabs and a column to new class page #2879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 24, 2023
3 tasks
MarvinOehlerkingCap
previously requested changes
Nov 2, 2023
| classId: selectedItem.value.id, | ||
| query: schoolYearQueryType.value, | ||
| }; | ||
| await groupModule.deleteClass(deleteQuery); | ||
| } | ||
| }; | ||
|
|
||
| const onUpdateSortBy = async (sortBy: string) => { |
There was a problem hiding this comment.
a composable instead of a store would be so nice...
# Conflicts: # src/serverApi/v3/api.ts
arnegns
approved these changes
Nov 3, 2023
|
Kudos, SonarCloud Quality Gate passed! |
IgorCapCoder
dismissed
MarvinOehlerkingCap’s stale review
solved last problem after eob :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Links to Ticket and related Pull-Requests
https://ticketsystem.dbildungscloud.de/browse/N21-1318
hpi-schul-cloud/schulcloud-server#4496
hpi-schul-cloud/e2e-system-tests#154
hpi-schul-cloud/schulcloud-client#3341
Changes
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging