Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-4550 - Browser back on page Tools does not lead to previous page #2889

Merged
merged 21 commits into from
Nov 6, 2023

Conversation

davwas
Copy link
Contributor

@davwas davwas commented Oct 30, 2023

Short Description

QA note:
Change tested on https://brb-bc-4550-browser-back-on-tools-page.cd.dbildungscloud.dev/ env
No issues found. Works fin on Chrome and Firefox.

Links to Ticket and related Pull-Requests

https://ticketsystem.dbildungscloud.de/browse/BC-4550

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@davwas davwas added the WIP someone is working on that label Oct 30, 2023
@davwas davwas self-assigned this Oct 30, 2023
@davwas davwas added waiting for review Someone should review this ASAP and removed WIP someone is working on that labels Oct 30, 2023
wiaderwek
wiaderwek previously approved these changes Oct 30, 2023
src/pages/rooms/RoomDetails.page.vue Outdated Show resolved Hide resolved
src/pages/rooms/RoomDetails.page.vue Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

84.6% 84.6% Coverage
0.0% 0.0% Duplication

@davwas davwas merged commit b01b942 into main Nov 6, 2023
41 of 42 checks passed
@davwas davwas deleted the BC-4550-browser-back-on-tools-page branch November 6, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for review Someone should review this ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants