Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-5557 - Refactoring Admin Tables Data Filter #2954

Merged
merged 68 commits into from
Jan 15, 2024
Merged

BC-5557 - Refactoring Admin Tables Data Filter #2954

merged 68 commits into from
Jan 15, 2024

Conversation

muratmerdoglu-dp
Copy link
Contributor

Short Description

Links to Ticket and related Pull-Requests

https://ticketsystem.dbildungscloud.de/browse/BC-5557

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@muratmerdoglu-dp
initial implementation of datafilter
d32ef7e
@muratmerdoglu-dp
Merge branch 'BC-3844-vue3-webpack' into vue3-data-filter
8a872b9
@muratmerdoglu-dp
move folders
e318e58
@muratmerdoglu-dp
create filter dialog component
5359761
@muratmerdoglu-dp
create components and basic functionilities
30b6787
@muratmerdoglu-dp
BC-5557: add date picker in timebetween component
b94d717
@muratmerdoglu-dp
chore: remove console.log()
bfea3a2
@muratmerdoglu-dp
BC-5557: add composable file for filtering
b88dc93
@muratmerdoglu-dp
BC-5557: move logics into the composable
615df4c
@muratmerdoglu-dp
BC-5557: add feature on chips to open the dialog
87cfbb2
@muratmerdoglu-dp
BC-5557: create filterApi composable
893bced
@muratmerdoglu-dp
BC-5557: create and move composables
93e47ab
@muratmerdoglu-dp
chore: fix imports
77e5fdf
@muratmerdoglu-dp
BC-5557: implement saving local storage
47f0282
@muratmerdoglu-dp
BC-5557: create update method in student overview
08b3dd6
@muratmerdoglu-dp
BC-5557: create ListSelection component
088d9d3
@muratmerdoglu-dp
BC-5557: delete Classes and Registration comps
fb09441
@muratmerdoglu-dp
BC-5557: add default dates
edacf31
@muratmerdoglu-dp
BC-5557: set filterQuery after mounting component
c9e89a1
@muratmerdoglu-dp
BC-5557: add selected filters to dialog options
16285a1
@muratmerdoglu-dp
chore: clean up variable names
21b2585
@muratmerdoglu-dp
chore: add type to prop
71b2d15
@muratmerdoglu-dp
chore: fix compaling error
0b0d746
@muratmerdoglu-dp
BC-5557: add functionality to teachers page
e296033
@muratmerdoglu-dp
BC-5557: add features both students and teachers
f212671
@muratmerdoglu-dp
chore: delete feature folder
3cf5590
@muratmerdoglu-dp
chore: remove unnecessary comments
d9009e9
@muratmerdoglu-dp
Merge branch 'BC-3844-vue3-webpack' into BC-5557-vue3-data-filter
7c48717
@muratmerdoglu-dp
BC-5557: install pinia
a475b71
@muratmerdoglu-dp
delete filterApi composable file
ee2d328
@muratmerdoglu-dp
Merge branch 'BC-3844-vue3-webpack' into BC-5557-vue3-data-filter
f5d1e3e
@muratmerdoglu-dp
BC-5557: add unit tests for filterActionButtons component
8343fbd
@muratmerdoglu-dp
BC-5557: add unit tests for FilterChips component
0752c67
@muratmerdoglu-dp
BC-5557: add unit tests for ListSelection component
b622d2c
@muratmerdoglu-dp
BC-5557: use i18n keys in DateBetween component
c467643
@muratmerdoglu-dp
chore: create unit test for localStorage composable
a5241a1
@muratmerdoglu-dp
chore: fix type
6934e9a
@muratmerdoglu-dp
chore: remove required props in components
10cc216
@muratmerdoglu-dp
BC-5557: implement unit tests for the FilterDialog component
d57cb73
@muratmerdoglu-dp
BC:5557: implement unit tests for DateBetween component
fe822eb
@muratmerdoglu-dp
BC-5557: implement unit tests for localStorage composable file
af81fc0
@muratmerdoglu-dp
Merge branch 'BC-3844-vue3-webpack' into BC-5557-vue3-data-filter
157970a
@muratmerdoglu-dp
BC:5557: implement unit tests for filter.composable file
ff803b0
@muratmerdoglu-dp
BC-5557: move classlist logic to main component
98ba1cb
@muratmerdoglu-dp
BC-5557: implement unit tests for main component
99c9c37
@muratmerdoglu-dp
BC-5557: delete old filter components and files
2b12bc2
@muratmerdoglu-dp
Merge branch 'BC-3844-vue3-webpack' into BC-5557-vue3-data-filter
ad0ae7a
uidp
uidp approved these changes Jan 12, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
src/components/organisms/DataFilter/DataFilter.vue Show resolved Hide resolved
src/components/organisms/DataFilter/DataFilter.unit.ts Outdated Show resolved Hide resolved
src/components/organisms/DataFilter/FilterDialog.unit.ts Outdated Show resolved Hide resolved
src/components/organisms/DataFilter/composables/localStorage.composable.ts Outdated Show resolved Hide resolved
src/components/organisms/DataFilter/composables/filter.composable.ts Outdated Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
@muratmerdoglu-dp muratmerdoglu-dp merged commit 152ed8a into BC-3844-vue3-webpack Jan 15, 2024
8 of 10 checks passed
@muratmerdoglu-dp muratmerdoglu-dp deleted the BC-5557-vue3-data-filter branch January 15, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uidp uidp uidp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muratmerdoglu-dp @uidp