Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-6842 - Adjust design system #3170

Merged
merged 71 commits into from
Apr 8, 2024
Merged

Conversation

NFriedo
Copy link
Contributor

@NFriedo NFriedo commented Mar 25, 2024

Short Description

Adjust system in order to create a uniform design system according to Material Design principles.

Links to Ticket and related Pull-Requests

BC-6842
schulcloud-client: hpi-schul-cloud/schulcloud-client#3432

Changes

  • convert vuetify options js to ts
  • theme colors on-surface, on-background, on-white are set for all themes
  • theme variables high-emphasis-opacity, medium-emphasis-opacity, disabled-opacity are set
  • secondary color (secondary, secondary-lighten-1, secondary-darken-1) removed
  • remove unnecessary css for components
  • remove theme black color

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@NFriedo NFriedo added the WIP someone is working on that label Mar 25, 2024
@hoeppner-dataport hoeppner-dataport removed the WIP someone is working on that label Apr 8, 2024
Copy link

sonarqubecloud bot commented Apr 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
67.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@hoeppner-dataport hoeppner-dataport merged commit c76345c into main Apr 8, 2024
47 of 51 checks passed
@hoeppner-dataport hoeppner-dataport deleted the BC-6842-adjust-design-system branch April 8, 2024 10:36
bergatco pushed a commit that referenced this pull request May 6, 2024
Adjust system in order to create a uniform design system according to Material Design principles.
- convert vuetify options js to ts
- theme colors on-surface, on-background, on-white are set for all themes
- theme variables high-emphasis-opacity, medium-emphasis-opacity, disabled-opacity are set
- secondary color (secondary, secondary-lighten-1, secondary-darken-1) removed
- remove unnecessary css for components
- remove theme black color
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants