Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-6929 - new topbar #3219

Merged
merged 35 commits into from
May 6, 2024
Merged

BC-6929 - new topbar #3219

merged 35 commits into from
May 6, 2024

Conversation

odalys-dataport
Copy link
Contributor

@odalys-dataport odalys-dataport commented Apr 24, 2024 •
edited by atlldwp
Loading

Short Description

Links to Ticket and related Pull-Requests

BC-6929
hpi-schul-cloud/dof_app_deploy#858
hpi-schul-cloud/schulcloud-server#4979

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@odalys-dataport odalys-dataport added the WIP someone is working on that label Apr 24, 2024
@odalys-dataport odalys-dataport self-assigned this Apr 24, 2024
This was referenced May 2, 2024
Merged
Merged
@odalys-dataport odalys-dataport removed the WIP someone is working on that label May 5, 2024
MartinSchuhmacher
MartinSchuhmacher reviewed May 6, 2024
View reviewed changes
src/App.vue Show resolved Hide resolved
src/App.vue Outdated Show resolved Hide resolved
src/modules/ui/layout/topbar/StatusAlerts.vue Outdated Show resolved Hide resolved
src/modules/ui/qr-code/QRCode.vue Show resolved Hide resolved
src/vuetify.options.ts Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@odalys-dataport odalys-dataport merged commit 1db354f into main May 6, 2024
48 of 49 checks passed
@odalys-dataport odalys-dataport deleted the BC-6929-new-topbar branch May 6, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinSchuhmacher MartinSchuhmacher MartinSchuhmacher approved these changes

@uidp uidp uidp approved these changes

Assignees

@odalys-dataport odalys-dataport

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@odalys-dataport @MartinSchuhmacher @uidp