Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N21-1885 generate api and removes ctl tool version #3244

Merged
merged 11 commits into from
May 17, 2024

Conversation

arnegns
Copy link
Contributor

@arnegns arnegns commented May 14, 2024

Short Description

This pr generates the api and removes the version of tools since it will be checked when launchling or loading tools.

Links to Ticket and related Pull-Requests

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

Copy link
Contributor

@IgorCapCoder IgorCapCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are still remnants of toolVersion present in code, i found them in:

  • schoolExternalToolFactory.ts
  • schoolExternalToolConfigurationTemplateResponseFactory.ts
  • schoolExternalToolConfigurationTemplate.factory.ts
  • school-external-tools.unit.ts

And just by writing these filenames i realised, that our namings are a mess 😅

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@IgorCapCoder IgorCapCoder merged commit 972d0a1 into main May 17, 2024
47 of 49 checks passed
@IgorCapCoder IgorCapCoder deleted the N21-1885-refactor-ctl-dos branch May 17, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants