Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-7823 - implement rooms page #3370

Merged
merged 27 commits into from
Aug 29, 2024
Merged

BC-7823 - implement rooms page #3370

merged 27 commits into from
Aug 29, 2024

Conversation

uidp
Copy link
Contributor

@uidp uidp commented Aug 21, 2024 •
edited
Loading

Short Description

As a teacher, I want to get an overview over all rooms I am part of or which I created.

Links to Ticket and related Pull-Requests

BC-7823

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@uidp uidp added the WIP someone is working on that label Aug 21, 2024
uidp added 12 commits August 22, 2024 16:13
@uidp uidp removed the WIP someone is working on that label Aug 26, 2024
@uidp uidp requested review from odalys-dataport and MartinSchuhmacher and removed request for odalys-dataport August 26, 2024 14:36
MartinSchuhmacher
MartinSchuhmacher reviewed Aug 26, 2024
View reviewed changes
src/modules/feature/room-directory/RoomGrid.vue Outdated Show resolved Hide resolved
src/types/room/Room.ts Show resolved Hide resolved
src/modules/feature/room-directory/RoomGrid.vue Outdated Show resolved Hide resolved
odalys-dataport
odalys-dataport requested changes Aug 27, 2024
View reviewed changes
config/webpack/webpack.common.js Outdated Show resolved Hide resolved
src/locales/en.ts Outdated Show resolved Hide resolved
src/modules/feature/room-directory/RoomGrid.vue Outdated Show resolved Hide resolved
src/modules/feature/room-directory/RoomGrid.vue Outdated Show resolved Hide resolved
src/modules/feature/room-directory/RoomTile.vue Outdated Show resolved Hide resolved
src/modules/feature/room-directory/RoomTile.vue Outdated Show resolved Hide resolved
@odalys-dataport odalys-dataport self-requested a review August 29, 2024 13:54
@uidp uidp enabled auto-merge (squash) August 29, 2024 13:55
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@uidp uidp merged commit cd28aa1 into main Aug 29, 2024
137 of 143 checks passed
@uidp uidp deleted the BC-7823-add-rooms-page-2 branch August 29, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinSchuhmacher MartinSchuhmacher MartinSchuhmacher left review comments

@odalys-dataport odalys-dataport odalys-dataport approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uidp @MartinSchuhmacher @odalys-dataport