-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC-8147 - Upgrade to ESLint 9 #3411
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfig-typescript to newest version
uidp
previously approved these changes
Oct 25, 2024
uidp
previously approved these changes
Oct 25, 2024
NFriedo
changed the title
BC-8147 - [Research] New eslint flat config
BC-8147 - Upgrade to ESLint 9
Oct 28, 2024
uidp
approved these changes
Oct 28, 2024
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
In Eslint 9, there is a new default config format system, the flat config. Its also possible to use the new format in Eslint v8 (current: eslintrc format).
We want try to use the flat config and see if there are any problems.
This PR will upgrade ESLint 8 to ESLint 9.
Links to Ticket and related Pull-Requests
BC-8147
Changes
configType: "flat"
option toESLintWebpackPlugin
inwebpack.common.js
eslintPath: "eslint/use-at-your-own-risk"
, this is experimental@vue/eslint-config-typescript
is not supporting the new format yet:FlatCompat
from@eslint/eslintrc
ignores
config object ineslint.config.js
Commits 7.10.24:
@vue/eslint-config-typescript
to version 14eslint 9.12.0
"@typescript-eslint/no-unused-vars": "warn"
, because there are many eslint errors in catch blockcaughtErrors: all
for 'catch' blocks"no-unused-vars
for @typescript-eslint/no-unused-vars"@typescript-eslint/no-empty-object-type": ["error", { allowInterfaces: "with-single-extends" },],
"@typescript-eslint/no-require-imports": "off"
for noweslintPath: "eslint/use-at-your-own-risk"
because this was just needed vor eslint 8Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging