Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-2167 preferred tools for boards #3419

Merged
merged 32 commits into from
Oct 25, 2024
Merged

N21-2167 preferred tools for boards #3419

merged 32 commits into from
Oct 25, 2024

Conversation

IgorCapCoder
Copy link
Contributor

@IgorCapCoder IgorCapCoder commented Oct 8, 2024 •
edited by GordonNicholasCap
Loading

Short Description

  • add preferred tool icons to addElement Dialog
  • create external tool element directly after clicking icon in addElement when no custom paramter is needed
  • open configuration dialog after clicking icon in addElement when at least 1 custom parameter is needed

Links to Ticket and related Pull-Requests

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@IgorCapCoder IgorCapCoder mentioned this pull request Oct 8, 2024
Merged
1 task
@MBergCap MBergCap mentioned this pull request Oct 9, 2024
Merged
3 tasks
@MBergCap MBergCap mentioned this pull request Oct 11, 2024
Merged
1 task
GordonNicholasCap
GordonNicholasCap requested changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@GordonNicholasCap GordonNicholasCap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are many, but it looks fine. There are some errors that need fixing.

src/modules/data/board/cardActions/cardRestApi.composable.unit.ts Outdated Show resolved Hide resolved
src/modules/data/board/Card.store.ts Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
91.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@IgorCapCoder IgorCapCoder merged commit dda3247 into main Oct 25, 2024
70 checks passed
@IgorCapCoder IgorCapCoder deleted the N21-2167-preferred-tools-for-boards branch October 25, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GordonNicholasCap GordonNicholasCap GordonNicholasCap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IgorCapCoder @GordonNicholasCap @MBergCap