BC-8578 - Remove Visibility Alert From Board #3516
Conversation
| @@ -328,25 +326,9 @@ onUnmounted(() => { | |||
| resetNotifierModule(); | |||
| }); | |||
|
|
|||
| const setAlert = useDebounceFn(() => { | |||
There was a problem hiding this comment.
Remove import of useDebounceFn above
There was a problem hiding this comment.
- this one still needs to be removed:
BC-8578 - Remove Visibility Alert From Board #3516 (comment)
| } from "@@/tests/test-utils/setup"; | ||
| import BoardDraftChip from "./BoardDraftChip.vue"; | ||
|
|
||
| describe("@feature-board/BoardDraftChip", () => { |
There was a problem hiding this comment.
what do you think about two additional tests for text in VChip and VTooltip?
There was a problem hiding this comment.
Imo this falls under the category "testing the framework" as there is no logic or changing texts in this component.
There was a problem hiding this comment.
Hm, maybe it would make sense to check if the correct text is rendered inside the component. Something like:
it("should render the text message", () => {
const wrapper = setup();
expect(wrapper.text()).toContain("common.words.draft");
});There was a problem hiding this comment.
Can do. Not sure how easy it is to test for the tooltip text though
There was a problem hiding this comment.
Right. I confused the two components, sorry.
|
Short Description
Removes alert from board about its visibility and adds a tooltip to the "draft-chip".
Links to Ticket and related Pull-Requests
BC-8578
Changes
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging