BC-7124 - Remove etherpad sessions on logout (#3450)

hpi-schul-cloud · May 21, 2024 · 0363c8e · 0363c8e
1 parent 38fa3d0
commit 0363c8e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/controllers/login.js b/controllers/login.js
@@ -468,6 +468,13 @@ router.get('/logout/', (req, res, next) => {
 		.catch((err) => {
 			logger.error('error during logout.', formatError(err));
 		});
+
+	api(req, { version: 'v3' })
+		.del('/collaborative-text-editor/delete-sessions') // async, ignore result
+		.catch((err) => {
+			logger.error('can not delete etherpad client sessions', formatError(err));
+		});
+
 	return authHelper.clearCookie(req, res, sessionDestroyer)
 	// eslint-disable-next-line prefer-template, no-return-assign
 		.then(() => {

diff --git a/helpers/authentication.js b/helpers/authentication.js
@@ -64,6 +64,7 @@ const clearCookie = async (req, res, options = { destroySession: false }) => {
 			});
 		});
 	}
+
 	res.clearCookie('jwt');
 	// this is deprecated and only used for cookie removal from now on,
 	// and can be removed after one month (max cookie lifetime from life systems)
-Original file line number
+Diff line change
@@ Expand Up @@
     			});
     		});
     	}
     	res.clearCookie('jwt');
     	// this is deprecated and only used for cookie removal from now on,
     	// and can be removed after one month (max cookie lifetime from life systems)
@@ Expand Down @@