N21-1269 review fixes

hpi-schul-cloud · Sep 22, 2023 · 6227045 · 6227045
1 parent 1617f76
commit 6227045
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/controllers/oauth2.js b/controllers/oauth2.js
@@ -155,8 +155,10 @@ router.get('/username/:pseudonym', async (req, res, next) => {
 						qs: { id: pseudonymResponse.userId },
 						$limit: 1,
 					});
-				completeName = `${userResponse.data[0].firstName} ${userResponse.data[0].lastName}`;
-				shortName = `${userResponse.data[0].firstName} ${userResponse.data[0].lastName.charAt(0)}.`;
+				if (userResponse.data?.length === 1) {
+					completeName = `${userResponse.data[0].firstName} ${userResponse.data[0].lastName}`;
+					shortName = `${userResponse.data[0].firstName} ${userResponse.data[0].lastName.charAt(0)}.`;
+				}
 			} else {
 				const feathersPseudonymResponse = await api(req)
 					.get('/pseudonym', {