Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-482-character-not-shown-properly #3291

Merged
merged 6 commits into from
Sep 14, 2023

Conversation

Michaellinaresxk
Copy link
Contributor

@Michaellinaresxk Michaellinaresxk commented Aug 29, 2023

Screen Shot 2023-08-29 at 2 17 54 PM …reation.

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-482

Changes

Added functionality to display the character "&" instead of &amp on theme creation.

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Edit

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@Michaellinaresxk Michaellinaresxk changed the title Added functionality to display & character instead of &amp on theme c… BC-482-character-not-shown-properly Aug 29, 2023
Copy link
Contributor

@bn-pass bn-pass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the ticket's description only mentions the & character, but in my opinion the solution is too limited - please try to use some generic function to properly decode any possible special characters. Maybe you can use a similar solution like for the BC-1033 ticket as the issue seems to be exactly the same.

Copy link
Contributor

@bn-pass bn-pass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better now, but please do this check-and-decode for each field separately - in this solution if, e.g., course description would be undefined, the course name would not be properly decoded. So just do it the same way, but for every field separately.

@Michaellinaresxk Michaellinaresxk force-pushed the BC-482-character-not-shown-properly branch 2 times, most recently from eeb986e to 2487125 Compare September 7, 2023 13:53
controllers/topics.js Fixed Show fixed Hide fixed
controllers/topics.js Fixed Show fixed Hide fixed
controllers/topics.js Fixed Show fixed Hide fixed
controllers/topics.js Fixed Show fixed Hide fixed
@Michaellinaresxk Michaellinaresxk force-pushed the BC-482-character-not-shown-properly branch from 55f575b to 6e191e8 Compare September 13, 2023 16:16
@Michaellinaresxk Michaellinaresxk force-pushed the BC-482-character-not-shown-properly branch from d0b2869 to 318faac Compare September 13, 2023 21:12
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Michaellinaresxk Michaellinaresxk merged commit 3b7c4d0 into main Sep 14, 2023
@Michaellinaresxk Michaellinaresxk deleted the BC-482-character-not-shown-properly branch September 14, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants