-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC-482-character-not-shown-properly #3291
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know the ticket's description only mentions the & character, but in my opinion the solution is too limited - please try to use some generic function to properly decode any possible special characters. Maybe you can use a similar solution like for the BC-1033 ticket as the issue seems to be exactly the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better now, but please do this check-and-decode for each field separately - in this solution if, e.g., course description would be undefined, the course name would not be properly decoded. So just do it the same way, but for every field separately.
eeb986e
to
2487125
Compare
55f575b
to
6e191e8
Compare
d0b2869
to
318faac
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/BC-482
Changes
Added functionality to display the character "&" instead of & on theme creation.
Data Security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Approval for review