Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-4900 - Red line shows when removing task #3306

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

davwas
Copy link
Contributor

@davwas davwas commented Sep 18, 2023

Description

QA note:
I tested your change on env:
https://default-bc-4900-red-line-shows-when-removing-task.cd.dbildungscloud.dev/
https://default-bc-4900-red-line-shows-when-removing-task.cd.dbildungscloud.dev/
https://brb-bc-4900-red-line-shows-when-removing-task.cd.dbildungscloud.dev/
No issues found. Red line at the top no longer appears.

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-4900

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@davwas davwas added the WIP label Sep 18, 2023
@davwas davwas self-assigned this Sep 18, 2023
@davwas davwas changed the title BC 4900 - Red line shows when removing task BC-4900 - Red line shows when removing task Sep 18, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@davwas davwas merged commit 8251a45 into main Sep 22, 2023
36 of 37 checks passed
@davwas davwas deleted the BC-4900-red-line-shows-when-removing-task branch September 22, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants