Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-5041 - Remove consent notice in manual registration (SC BB & NBC) #3310

Merged
merged 7 commits into from
Sep 22, 2023

Conversation

davwas
Copy link
Contributor

@davwas davwas commented Sep 21, 2023

Description

QA note:
Change was tested on env:
https://brb-bc-5041-remove-consent-notice.cd.dbildungscloud.dev/
https://brb-bc-5041-remove-consent-notice.cd.dbildungscloud.dev/
https://brb-bc-5041-remove-consent-notice.cd.dbildungscloud.dev/
No iseuss found. All acceptance criteria done.

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-5041

Changes

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@davwas davwas added the WIP label Sep 21, 2023
@davwas davwas self-assigned this Sep 21, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@davwas davwas merged commit 185020c into main Sep 22, 2023
36 of 37 checks passed
@davwas davwas deleted the BC-5041-remove-consent-notice branch September 22, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants