Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-5119-Prevent create new neXboard (Front) #3313

Merged
merged 18 commits into from
Nov 20, 2023
Merged

BC-5119-Prevent create new neXboard (Front) #3313

merged 18 commits into from
Nov 20, 2023

Conversation

Michaellinaresxk
Copy link
Contributor

@Michaellinaresxk Michaellinaresxk commented Sep 22, 2023 •
edited
Loading

Description

This is the fronted implementation to avoid teachers to create a new nexboard, removing the button of
nextBoard, on edit-topic page.

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-5119
hpi-schul-cloud/schulcloud-server#4522

Changes

  • Remove the nextBoard button on edit-topic view for teacher role.
  • Changed FEATURE_NEXBOARD_ENABLED to false

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@Michaellinaresxk Michaellinaresxk changed the title Hide nextBoard button for teacher. BC-5119-Preventcreating new neXboard Sep 26, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Michaellinaresxk Michaellinaresxk force-pushed the BC-5119-Prevent-creating-new-neXboards branch from cf6e0dc to cb3d689 Compare November 8, 2023 10:29
@Michaellinaresxk Michaellinaresxk changed the title BC-5119-Preventcreating new neXboard BC-5119-Prevent create new neXboard Nov 8, 2023
@Michaellinaresxk Michaellinaresxk changed the title BC-5119-Prevent create new neXboard BC-5119-Prevent create new neXboard (Front) Nov 8, 2023
bn-pass
bn-pass suggested changes Nov 13, 2023
View reviewed changes
@Michaellinaresxk Michaellinaresxk force-pushed the BC-5119-Prevent-creating-new-neXboards branch from e0d22fd to 8eda083 Compare November 13, 2023 15:29
bn-pass
bn-pass suggested changes Nov 14, 2023
View reviewed changes
bn-pass
bn-pass suggested changes Nov 16, 2023
View reviewed changes
@Michaellinaresxk Michaellinaresxk force-pushed the BC-5119-Prevent-creating-new-neXboards branch from 25da5c8 to aabe695 Compare November 17, 2023 08:57
bn-pass
bn-pass suggested changes Nov 17, 2023
View reviewed changes
@Michaellinaresxk Michaellinaresxk force-pushed the BC-5119-Prevent-creating-new-neXboards branch from 30e5de5 to f2c4d6d Compare November 17, 2023 14:45
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@virgilchiriac virgilchiriac mentioned this pull request Nov 17, 2023
Closed
3 tasks
@Michaellinaresxk Michaellinaresxk merged commit eee257a into main Nov 20, 2023
@Michaellinaresxk Michaellinaresxk deleted the BC-5119-Prevent-creating-new-neXboards branch November 20, 2023 09:04
uidp added a commit that referenced this pull request Nov 22, 2023
@uidp
Revert "BC-5119-Prevent create new neXboard (Front) (#3313)"
9bb37e0 
This reverts commit eee257a.
NFriedo added a commit that referenced this pull request Nov 29, 2023
@NFriedo
Revert "BC-5119-Prevent create new neXboard (Front) (#3313)"
686e0cb 
This reverts commit eee257a.
NFriedo added a commit that referenced this pull request Nov 29, 2023
@NFriedo
BC-5901: Revert "BC-5119-Prevent create new neXboard (Front) (#3313)" (…
4148ced 
…#3357)

The schulcloud-client PR from BC-5119 was merged before the other PRs from that ticket were ready. Therefore we want to revert that merge.

* reverts commit eee257a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virgilchiriac virgilchiriac virgilchiriac approved these changes

@odalys-dataport odalys-dataport odalys-dataport approved these changes

@bn-pass bn-pass bn-pass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Michaellinaresxk @virgilchiriac @odalys-dataport @bn-pass